Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to close client #81

Open
meesii opened this issue Mar 4, 2023 · 6 comments
Open

how to close client #81

meesii opened this issue Mar 4, 2023 · 6 comments

Comments

@meesii
Copy link

meesii commented Mar 4, 2023

When I need to close the client, I call the close method, but the program reports an error.

image

@meesii
Copy link
Author

meesii commented Mar 4, 2023

I use 3.0.4 version

@RogerHardiman
Copy link
Collaborator

looks like we need try/catch around the Socket Read code to handle the case where the low level socket has been closed in the Close() function

@meesii
Copy link
Author

meesii commented Mar 7, 2023

It's my way of fixing it.
image

@j8jacobs
Copy link

j8jacobs commented May 1, 2023

@RogerHardiman I'm facing the same issue, same version. Any updates on this? I'm currently diving in so any guidance is appreciated. Happy to submit a PR or report back here if I find anything.

On that note - does this error mean that the connection has already closed? In my initial proof-of-concept implementation, I just decided to never close any of the connections, which seemed wrong. Do you see any side-effects coming of that, or you think I'm safe to just ignore?

Thank you btw, this library has greatly helped.

@meesii meesii closed this as completed May 30, 2023
@j8jacobs
Copy link

j8jacobs commented May 30, 2023

@meesii is this now functional? please share workaround if you found one.
Doing what you suggested did not work for me - the client was never closing fully, and thus, all audio was stuck listening for backchannel.

@RogerHardiman RogerHardiman reopened this Jun 11, 2023
@RogerHardiman
Copy link
Collaborator

I have created a branch called teardown.
Please can you test it.

Thanks
Roger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants