fix: move icons to /priv/static to aid precompilation + webpack updates (#1949)

Author: thecristen

.dockerignore

@@ -8,7 +8,8 @@ deps
 erl_crash.dump
 build.sh
 deploy.sh
-priv/static
+/priv/static/*
+!/priv/static/icon-svg/
 aws
 dotcom-build.zip
 bin

.github/actions/build-app/action.yml

@@ -10,7 +10,7 @@ runs:
   using: "composite"
   steps:
   - name: Cache _build
-    uses: actions/cache@v3
+    uses: actions/cache@v4
     with:
       path: |
         _build
@@ -25,6 +25,7 @@ runs:
   - name: Compile application (if needed)
     shell: bash
     run: |
-      MIX_ENV=test mix compile.assets
+      npm --prefix assets run webpack:build
+      npm --prefix assets run webpack:build:react
       MIX_ENV=test mix compile --all-warnings
     if: steps.build-cache.outputs.cache-hit != 'true'

.gitignore

@@ -51,7 +51,8 @@ node_modules
 # Since we are building assets from assets,
 # we ignore priv/static. You may want to comment
 # this depending on your deployment strategy.
-/priv/static/
+/priv/static/*
+!/priv/static/icon-svg/
 
 # The config/prod.secret.exs file by default contains sensitive
 # data and you should not commit it into version control.

README.md

@@ -110,16 +110,6 @@ Welcome to [Dotcom](https://www.notion.so/mbta-downtown-crossing/Dotcom-6aa7b0f0
 
     Minor note - you may see a prompt to upgrade `npm`. This isn't needed, and `"lockfileVersion": 1` in our `assets/package-lock.json` file means it was generated with an `npm` version prior to 7.
 
-1.  Build the project:
-    ```
-    npm run build
-    ```
-    * If this fails try adding the following line to `defp deps` section in `mix.exs`:
-    ```
-    {:fs, git: "https://github.com/synrc/fs.git", override: true}
-    ```
-
-  `npm run build` does several things: builds the Phoenix application assets, builds all the front-end assets, and then compiles the entire Elixir application.
 
 1. Set up required environment variables:
     ```

assets/css/_events.scss

@@ -28,8 +28,7 @@
 
 .m-event-listing {
   @include media-breakpoint-down(xs) {
-    /* stylelint-disable-next-line scss/operator-no-unspaced */
-    margin: 0 -$base-spacing;
+    margin: 0 (-$base-spacing);
   }
 }