refactor: De-umbrella this application (#1845)

Additional changes of note:
* Remove distillery in favor of native Elixir releases
* Refactors the configuration files, uses `runtime.exs` now
* Updates excoveralls, adds file info to coverage output
* Adds a suite of smoke tests, which
* Deprecates the Elixir tests which use Wallaby

Author: thecristen

.dockerignore

@@ -8,9 +8,9 @@ deps
 erl_crash.dump
 build.sh
 deploy.sh
-apps/site/priv/static
+priv/static
 aws
-site-build.zip
+dotcom-build.zip
 bin
 Dockerfile
 .dockerignore

.formatter.exs

@@ -1,9 +1,7 @@
 [
   inputs: [
     "mix.exs",
-    "apps/*/mix.exs",
-    "apps/*/{config,lib,test}/**/*.{ex,exs}",
-    "config/**/*.{ex,exs}",
+    "{config,lib,test}/**/*.{ex,exs}",
     "rel/**/*.{ex,exs}"
   ]
 ]

.github/CODEOWNERS

@@ -4,15 +4,15 @@
 *                                              @mbta/dotcom
 
 # CMS-related code
-/apps/cms/                                     @mbta/dotcom @amaisano
-site/content_rewriter.ex                       @mbta/dotcom @amaisano
-site/content_rewriters/                        @mbta/dotcom @amaisano
-site_web/controllers/cms_controller.ex         @mbta/dotcom @amaisano
-site_web/views/cms_view.ex                     @mbta/dotcom @amaisano
-site_web/views/page_content_view.ex            @mbta/dotcom @amaisano
-site_web/views/paragraph_view.ex               @mbta/dotcom @amaisano
-site_web/views/partial_view.ex                 @mbta/dotcom @amaisano
-site_web/views/teaser_view.ex                  @mbta/dotcom @amaisano
-site_web/views/helpers/cms_helpers.ex          @mbta/dotcom @amaisano
-site_web/views/helpers/cms_router_helpers.ex   @mbta/dotcom @amaisano
-site_web/templates/cms/                        @mbta/dotcom @amaisano
+cms/                                           @mbta/dotcom @amaisano
+dotcom/content_rewriter.ex                       @mbta/dotcom @amaisano
+dotcom/content_rewriters/                        @mbta/dotcom @amaisano
+dotcom_web/controllers/cms_controller.ex         @mbta/dotcom @amaisano
+dotcom_web/views/cms_view.ex                     @mbta/dotcom @amaisano
+dotcom_web/views/page_content_view.ex            @mbta/dotcom @amaisano
+dotcom_web/views/paragraph_view.ex               @mbta/dotcom @amaisano
+dotcom_web/views/partial_view.ex                 @mbta/dotcom @amaisano
+dotcom_web/views/teaser_view.ex                  @mbta/dotcom @amaisano
+dotcom_web/views/helpers/cms_helpers.ex          @mbta/dotcom @amaisano
+dotcom_web/views/helpers/cms_router_helpers.ex   @mbta/dotcom @amaisano
+dotcom_web/templates/cms/                        @mbta/dotcom @amaisano

.github/PULL_REQUEST_TEMPLATE.md

@@ -32,6 +32,6 @@
 * [ ] **Other accessibility checks** such as sufficient [color constrast](https://thinkdobecreate.com/articles/4-required-tests-before-shipping-new-features/#color-contrast), or whether the layout holds up at 200% [zoom level](https://thinkdobecreate.com/articles/4-required-tests-before-shipping-new-features/#visible-focus).
 
 #### New endpoints, or non-trivial changes to current endpoints
-* [ ] **Have we load-tested** any new pages or internal API endpoints that will receive significant traffic? [See load testing docs](./../apps/site/load_tests/README.md)
+* [ ] **Have we load-tested** any new pages or internal API endpoints that will receive significant traffic? [See load testing docs](./../load_tests/README.md)
 * [ ] **If this change involves routes,** does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?
 

.github/actions/build-app/action.yml

@@ -14,8 +14,8 @@ runs:
     with:
       path: |
         _build
-        apps/site/priv
-        apps/site/react_renderer/dist/app.js
+        priv
+        react_renderer/dist/app.js
       key: ci-application-cache-${{ github.sha }}
     id: build-cache
 

.github/actions/setup-all/action.yml

@@ -43,15 +43,15 @@ runs:
   - name: Restore cache of Node dependencies from package-lock.json
     uses: actions/cache@v3
     with:
-      path: apps/site/assets/node_modules
-      key: ci-nodejs-cache-${{ hashFiles('apps/site/assets/package-lock.json') }}
+      path: assets/node_modules
+      key: ci-nodejs-cache-${{ hashFiles('assets/package-lock.json') }}
     id: node-cache
 
   - name: Restore Cypress cache
     uses: actions/cache@v3
     with:
       path: ~/.cache/Cypress
-      key: ci-cypress-${{ hashFiles('apps/site/assets/package-lock.json') }}
+      key: ci-cypress-${{ hashFiles('assets/package-lock.json') }}
 
   - name: Install Node dependencies (if needed)
     if: ${{ steps.node-cache.outputs.cache-hit != 'true' }}

.github/dependabot.yml

@@ -12,7 +12,7 @@ updates:
       time: "09:00"
     open-pull-requests-limit: 1
   - package-ecosystem: "npm" # See documentation for possible values
-    directory: "/apps/site/assets" # Location of package manifests
+    directory: "assets" # Location of package manifests
     schedule:
       interval: "daily"
       time: "09:00"

.github/workflows/algolia-update.yml

@@ -28,13 +28,13 @@ jobs:
     - uses: actions/cache/restore@v3
       with:
         path: deps
-        key: ci-mix-cache-${{ hashFiles('**/mix.lock') }}
+        key: ci-mix-cache-${{ hashFiles('mix.lock') }}
         restore-keys: ci-mix-cache-
       # the running application runs Webpack to render React stuff :(, so need NPM too
     - uses: actions/cache/restore@v3
       with:
-        path: apps/site/assets/node_modules
-        key: ci-nodejs-cache-${{ hashFiles('apps/site/assets/package-lock.json') }}
+        path: assets/node_modules
+        key: ci-nodejs-cache-${{ hashFiles('assets/package-lock.json') }}
         restore-keys: ci-nodejs-cache-
     - env:
         ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}

.github/workflows/changed-files.yml

@@ -58,9 +58,9 @@ jobs:
             echo "ex=true" >> $GITHUB_OUTPUT
           else
             changes () { git diff --name-only --diff-filter=ACDMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} ; }
-            echo "js=$(changes | grep -E 'apps/site/assets/js/.*\.jsx?' | xargs)" >> $GITHUB_OUTPUT
-            echo "ts=$(changes | grep -E 'apps/site/assets/ts/.*\.tsx?' | xargs)" >> $GITHUB_OUTPUT
-            echo "scss=$(changes | grep -E 'apps/site/assets/css/.*\.scss' | xargs)" >> $GITHUB_OUTPUT
+            echo "js=$(changes | grep -E 'assets/js/.*\.jsx?' | xargs)" >> $GITHUB_OUTPUT
+            echo "ts=$(changes | grep -E 'assets/ts/.*\.tsx?' | xargs)" >> $GITHUB_OUTPUT
+            echo "scss=$(changes | grep -E 'assets/css/.*\.scss' | xargs)" >> $GITHUB_OUTPUT
             echo "ex=$(changes | grep -E '.*(\.exs?|\.eex)' | xargs)" >> $GITHUB_OUTPUT
           fi
       - name: "List changed files:"

.github/workflows/tests.yml

@@ -91,13 +91,13 @@ jobs:
       with:
         path: |
           _build
-          apps/site/priv
-          apps/site/react_renderer/dist/app.js
+          priv
+          react_renderer/dist/app.js
         key: ci-application-cache-${{ github.sha }}
     - env:
         RECAPTCHA_PUBLIC_KEY: 6LeIxAcTAAAAAJcZVRqyHh71UMIEGNQ_MXjiZKhI
         RECAPTCHA_PRIVATE_KEY: 6LeIxAcTAAAAAGG-vFI1TnRWxMZNFuojJ4WifJWe
-        REACT_BUILD_PATH: apps/site/react_renderer/dist/app.js
+        REACT_BUILD_PATH: react_renderer/dist/app.js
       run: npm run ci:unit:exunit
     - name: Upload coverage artifact
       if: ${{ always() && github.event.pull_request }}
@@ -165,25 +165,3 @@ jobs:
     - uses: actions/checkout@v4
     - uses: ./.github/actions/setup-all
     - run: npm run ci:format:ts
-
-  elixir_wallaby:
-    name: Integration tests / Elixir
-    runs-on: ubuntu-latest
-    needs: [file_changes, build_app]
-    if: ${{ needs.file_changes.outputs.any }}
-    steps:
-    - uses: actions/checkout@v4
-    - uses: ./.github/actions/setup-all
-    - uses: actions/cache/restore@v3
-      with:
-        path: |
-          _build
-          apps/site/priv
-          apps/site/react_renderer/dist/app.js
-        key: ci-application-cache-${{ github.sha }}
-    - uses: mbta/setup-chromedriver@master
-    - env:
-        RECAPTCHA_PUBLIC_KEY: 6LeIxAcTAAAAAJcZVRqyHh71UMIEGNQ_MXjiZKhI
-        RECAPTCHA_PRIVATE_KEY: 6LeIxAcTAAAAAGG-vFI1TnRWxMZNFuojJ4WifJWe
-        REACT_BUILD_PATH: apps/site/react_renderer/dist/app.js 
-      run: npm run ci:integration:ex