stack.v1.js and index.html updated to use d3.v4.min.js #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you have intentions of updating stack.js in the future. Until then, I hope this might be helpful. I've made minimal changes so that index.html and stack.v1.js use D3 v4 instead of v3. Rather than create the minified version, I removed stack.v1.min.js altogether. And I added d3.v4.min.js (unzipped from https://github.com/d3/d3/releases/download/v4.4.0/d3.zip) so that index.html could find it locally.
Thank you for all your outstanding work!