Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 4.2 #25

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Upgrade to Django 4.2 #25

merged 5 commits into from
Mar 1, 2024

Conversation

Viicos
Copy link

@Viicos Viicos commented Feb 14, 2024

No description provided.

Only one test failure appeared, as it was code making use of internal Django API
Of course, there's a high chance more things broke but aren't covered yet
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 54.95%. Comparing base (384d2e7) to head (dd48cc3).

Files Patch % Lines
vng_api_common/validators.py 47.05% 9 Missing ⚠️
vng_api_common/authorizations/validators.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   54.80%   54.95%   +0.15%     
==========================================
  Files          79       79              
  Lines        3642     3632      -10     
  Branches      538      590      +52     
==========================================
  Hits         1996     1996              
+ Misses       1543     1533      -10     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos force-pushed the 42-upgrade branch 2 times, most recently from 7d57e49 to bfcd1df Compare February 14, 2024 12:37
@Viicos
Copy link
Author

Viicos commented Feb 14, 2024

Next steps would be:

  • Remove drf-yasg: it seems to be compatible with 4.2 (although only 4.1 is explicitly stated as supported), but is badly maintained and will not work on Python 3.12
  • Figure out what to do with iso-639: will also not work with 3.12, not maintained anymore. Alternative: https://github.com/jacksonllee/iso639

Copy link

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ON + django4.2 - checked, works without errors
OZ + django3.2 - checked, there are some errors with validator
OZ + django4.2 - not checked, because it requires quite some work to update OZ itself and drc-cmis, before it can be tested. But I don't think it should block this PR.

So after minor remarks are addressed, it's good to go

vng_api_common/inspectors/query.py Outdated Show resolved Hide resolved
vng_api_common/caching/etags.py Show resolved Hide resolved
@Viicos Viicos force-pushed the 42-upgrade branch 3 times, most recently from cd6e0cd to dd48cc3 Compare February 28, 2024 15:51
@Viicos Viicos merged commit 9563533 into main Mar 1, 2024
12 checks passed
@Viicos Viicos deleted the 42-upgrade branch March 1, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants