Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove django choices #11

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Conversation

annashamray
Copy link

Done:

  • convert DjangoChoices into native models.TextChoices
  • remove depreciated ObjectTypes constant
  • remove description parameters from constants

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #11 (046b0ff) into main (b8ea21a) will decrease coverage by 0.19%.
The diff coverage is 88.98%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   53.30%   53.12%   -0.19%     
==========================================
  Files          78       78              
  Lines        3611     3603       -8     
  Branches      530      531       +1     
==========================================
- Hits         1925     1914      -11     
- Misses       1588     1592       +4     
+ Partials       98       97       -1     
Files Changed Coverage Δ
vng_api_common/audittrails/viewsets.py 38.46% <0.00%> (-0.38%) ⬇️
vng_api_common/inspectors/query.py 31.48% <0.00%> (ø)
vng_api_common/middleware.py 59.44% <0.00%> (ø)
vng_api_common/checks.py 61.90% <33.33%> (ø)
vng_api_common/constants.py 90.83% <92.59%> (-3.43%) ⬇️
vng_api_common/serializers.py 60.00% <100.00%> (-0.51%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

setup.cfg Show resolved Hide resolved
vng_api_common/constants.py Show resolved Hide resolved
@annashamray annashamray merged commit 0ab2f49 into main Sep 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants