Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ogg audio files on Safari via: #386

Open
mayeaux opened this issue Nov 17, 2020 · 2 comments
Open

Support ogg audio files on Safari via: #386

mayeaux opened this issue Nov 17, 2020 · 2 comments

Comments

@mayeaux
Copy link
Owner

mayeaux commented Nov 17, 2020

https://github.com/brion/ogv.js/

@mayeaux
Copy link
Owner Author

mayeaux commented Nov 17, 2020

Actually, the proper way will be to convert everything to .mp3

If people want native .ogg support they can do a PR with a flag to support alt formats, and then use ogv on the frontend for Safari

@BassOfBass
Copy link
Collaborator

But <audio> supports several <source> elements and the agent picks the one the value of type attribute it can understand, otherwise sends the request to server for each <source> until it gets the one it can understand. It does increase the storage sizes, but reduces the round trips to server and makes compatibility a lot less painful, especially since there is a way to provide a fallback in the form of direct link to the file anyway.
Will require a lot of rework, though.
For one, Upload.js has to be rewritten to accommodate to the array of sources (and tracks), and some details present on the model itself have to be moved in there. So it requires writing a separate migration script too.
After that rewriting media.pug will be a piece of cake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants