Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Auto-detected transfers should never group 2 transactions where the receiver date is prior to the sender date #1602

Open
zachgoll opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
🐛 Bug Something isn't working

Comments

@zachgoll
Copy link
Collaborator

zachgoll commented Jan 7, 2025

Given 2 transactions:

Date Amount Flow
2025-01-02 500 Outflow
2025-01-01 500 Inflow

The "outflow" (sender of the money) has a date after the "inflow" (receiver of money).

This should never be possible, but our "auto-matching" logic for transfers is not accounting for this. The current logic matches any 2 transactions that:

  • Are opposite amounts
  • Same currency
  • Within 4 days of each other (to account for settlement delays w/weekends and holidays)
  • From different accounts

We need to add:

  • Inflow date is after outflow date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant