Bug: Transaction in BRL but Market Price is in USD

[vinhadelli]

Describe the bug
The purchase is in BRL, but the market price is in USD. In the screenshot bellow, I have 4 shares of HTMX11, with a total value of 631.16 BRL, but since the market price is in USD, it is converting the value to 3258.24 BRL.

To Reproduce
Steps to reproduce the behavior:

1. Setup Maybe with BRL as the default currency
2. Import a transaction with the values in BRL
3. Check the data of the transaction, see that the market price is in USD

Expected behavior
I expected the market price to conform with the currency used to make the transaction

What version of Maybe are you using?
Self-hosted v0.2.0

What operating system and browser are you using?
Opera GX

Screenshots / Recordings

[zachgoll]

@vinhadelli can you share more details about how you imported this trade? Was it through a CSV import? Or was it through the add trade modal?

The ticker HTMX11 does not seem to be available in our securities provider (Synth), so I'm wondering how you were able to import this and get a price populated.

[vinhadelli]

Hello @zachgoll. I imported using a CSV that I generated from my usual investment website and customized to fit the format that Maybe expected.
The only provider that I configured was the Free Plan from Synth, when Maybe asked for an API Key.

HTMX11 is listed under the Bovespa Stocks, from Brazil.

Here is a example from the CSV (From left to right: Date, Ticker, Quantity, Value, Currency and Account)

[cybervirtu]

Hello @zachgoll, facing same problem when added a share from NSE india, Instead of INR of the share price it is taking USD and calculations are getting wrong based on it.

The current value need to be ₹ 1357.05 instead it is taking as $ and all the calculations are getting deviated because of it

[cybervirtu]

[cybervirtu]

@vinhadelli @aviflombaum @karbassi

[nikhilbadyal]

This happened because you imported data by CSV and the currency by default goes USD in the Database. @cybervirtu . I did this, this this , and this as a hack in my fork.

[zachgoll]

@nikhilbadyal is correct here. If you do not explicitly set the currency for your imported CSV, it will try to apply several defaults:

1. First looks at the CSV row for a currency column
2. Falls back to your family's currency preference (set in settings)

Currently, the currency dropdown is disabled for trades, but now that we support multi-currency investments, I think we could probably enable this:

[vinhadelli]

@zachgoll, to provide further data. In my install I did have the "currency" column in my CSV.

And my default currency in Maybe was already set as Brazilian Real (BRL)

[cybervirtu]

This happened because you imported data by CSV and the currency by default goes USD in the Database. @cybervirtu . I did this, this this , and this as a hack in my fork.

Hi @nikhilbadyal @zachgoll i hadn't imported any CSV i updated this manually and this happened for a manual entry

[nikhilbadyal]

@zachgoll to clarify more. The currency from CSV is not used at all, and this happens irrespective of the how data was added.(In fact with CSV import there is much more mess than manual entry). Because the stock data is populated(in security_prices and securities table) when it's fetched from synth and the final currency is decided by synth response only.

maybe/app/models/provider/synth.rb

Line 62 in 5d1a293

currency: price.dig("currency") || "USD"

And since synth doesn't provides. It fall back to USD and default currency.

I had this hack to extract correct currency.

def fetch_security_prices(ticker:, start_date:, end_date:, mic_code: nil)
    params = {
      start_date: start_date,
      end_date: end_date
    }

    params[:mic_code] = mic_code if mic_code.present?

    stock_exchange = StockExchange.find_by(mic: mic_code)

    # If no stock exchange is found for the given mic_code, we fall back to USD as default
    currency = stock_exchange ? stock_exchange.currency_code : "USD"

    prices = paginate(
      "#{base_url}/tickers/#{ticker}/open-close",
      params
    ) do |body|
      body.dig("prices").map do |price|
        {
          date: price.dig("date"),
          price: price.dig("close")&.to_f || price.dig("open")&.to_f,
          currency: currency
        }
      end
    end

    SecurityPriceResponse.new \
      prices: prices,
      success?: true,
      raw_response: prices.to_json
  rescue StandardError => error
    SecurityPriceResponse.new \
      success?: false,
      error: error,
      raw_response: error
  end

For CSV import more code is need to take exchange code as input to properly calculate the currency.

[zachgoll]

@nikhilbadyal @vinhadelli @cybervirtu thanks for the details on this, very helpful.

This is a tricky one—the code that @nikhilbadyal provided is not going to work in all cases, because Synth should be returning the currency that the price is quoted in. We need to treat that as our source of truth and then use ExchangeRate within the Maybe system to convert any prices that are not in the Account/Family currency. While the Synth provider does not respect the currency of the CSV import, the CSV import will post the entries to the account in the currency specified.

If you create the following trade:

• Ticker: ABC
• Currency: BRL
• Price: 100
• Qty: 1

And Synth returns:

• Ticker: ABC
• Currency: USD
• Price: 80

The trade should still be stated in BRL at a price of 100, but the holdings (and the trade drawer details view) should be converting the Synth USD value -> BRL using exchange rates.

In other words, we shouldn't be altering the Synth code, but rather, I think the solution needs to be implemented where we're syncing the holdings for the account, and in the drawer:

maybe/app/models/account/holding_calculator.rb

Lines 51 to 55 in 307a368

	price = security.dig(:prices)&.find { |p| p.date == date }
	next if price.blank?
	converted_price = Money.new(price.price, price.currency).exchange_to(account.currency, fallback_rate: 1).amount