Skip to content

Commit a9d2c61

Browse files
committed
Template update for nf-core/tools version 3.3.1
1 parent 4bf1fc9 commit a9d2c61

File tree

108 files changed

+6341
-1387
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

108 files changed

+6341
-1387
lines changed

.devcontainer/devcontainer.json

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"name": "nfcore",
3+
"image": "nfcore/gitpod:latest",
4+
"remoteUser": "gitpod",
5+
"runArgs": ["--privileged"],
6+
7+
// Configure tool-specific properties.
8+
"customizations": {
9+
// Configure properties specific to VS Code.
10+
"vscode": {
11+
// Set *default* container specific settings.json values on container create.
12+
"settings": {
13+
"python.defaultInterpreterPath": "/opt/conda/bin/python"
14+
},
15+
16+
// Add the IDs of extensions you want installed when the container is created.
17+
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
18+
}
19+
}
20+
}

.dockerignore

Lines changed: 0 additions & 5 deletions
This file was deleted.

.gitattributes

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,4 @@
11
*.config linguist-language=nextflow
2+
*.nf.test linguist-language=nextflow
3+
modules/nf-core/** linguist-generated
4+
subworkflows/nf-core/** linguist-generated

.github/.dockstore.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# Dockstore config version, not pipeline version
2+
version: 1.2
3+
workflows:
4+
- subclass: nfl
5+
primaryDescriptorPath: /nextflow.config
6+
publish: True

.github/CODEOWNERS

Lines changed: 0 additions & 1 deletion
This file was deleted.

.github/CONTRIBUTING.md

Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# `maxulysse/compile-latex`: Contributing Guidelines
2+
3+
Hi there!
4+
Many thanks for taking an interest in improving maxulysse/compile-latex.
5+
6+
We try to manage the required tasks for maxulysse/compile-latex using GitHub issues, you probably came to this page when creating one.
7+
Please use the pre-filled template to save time.
8+
9+
However, don't be put off by this template - other more general issues and suggestions are welcome!
10+
Contributions to the code are even more welcome ;)
11+
12+
## Contribution workflow
13+
14+
If you'd like to write some code for maxulysse/compile-latex, the standard workflow is as follows:
15+
16+
1. Check that there isn't already an issue about your idea in the [maxulysse/compile-latex issues](https://github.com/maxulysse/compile-latex/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
17+
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [maxulysse/compile-latex repository](https://github.com/maxulysse/compile-latex) to your GitHub account
18+
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
19+
4. Use `nf-core pipelines schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
20+
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged
21+
22+
If you're not used to this workflow with git, you can start with some [docs from GitHub](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests) or even their [excellent `git` resources](https://try.github.io/).
23+
24+
## Tests
25+
26+
You have the option to test your changes locally by running the pipeline. For receiving warnings about process selectors and other `debug` information, it is recommended to use the debug profile. Execute all the tests with the following command:
27+
28+
```bash
29+
nf-test test --profile debug,test,docker --verbose
30+
```
31+
32+
When you create a pull request with changes, [GitHub Actions](https://github.com/features/actions) will run automatic tests.
33+
Typically, pull-requests are only fully reviewed when these tests are passing, though of course we can help out before then.
34+
35+
There are typically two types of tests that run:
36+
37+
### Lint tests
38+
39+
`nf-core` has a [set of guidelines](https://nf-co.re/developers/guidelines) which all pipelines must adhere to.
40+
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core pipelines lint <pipeline-directory>` command.
41+
42+
If any failures or warnings are encountered, please follow the listed URL for more documentation.
43+
44+
### Pipeline tests
45+
46+
Each `nf-core` pipeline should be set up with a minimal set of test-data.
47+
`GitHub Actions` then runs the pipeline on this data to ensure that it exits successfully.
48+
If there are any failures then the automated tests fail.
49+
These tests are run both with the latest available version of `Nextflow` and also the minimum required version that is stated in the pipeline code.
50+
51+
## Patch
52+
53+
:warning: Only in the unlikely and regretful event of a release happening with a bug.
54+
55+
- On your own fork, make a new branch `patch` based on `upstream/main` or `upstream/master`.
56+
- Fix the bug, and bump version (X.Y.Z+1).
57+
- Open a pull-request from `patch` to `main`/`master` with the changes.
58+
59+
## Pipeline contribution conventions
60+
61+
To make the `maxulysse/compile-latex` code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.
62+
63+
### Adding a new step
64+
65+
If you wish to contribute a new step, please use the following coding standards:
66+
67+
1. Define the corresponding input channel into your new process from the expected previous process channel.
68+
2. Write the process block (see below).
69+
3. Define the output channel if needed (see below).
70+
4. Add any new parameters to `nextflow.config` with a default (see below).
71+
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core pipelines schema build` tool).
72+
6. Add sanity checks and validation for all relevant parameters.
73+
7. Perform local tests to validate that the new code works as expected.
74+
8. If applicable, add a new test in the `tests` directory.
75+
9. Update MultiQC config `assets/multiqc_config.yml` so relevant suffixes, file name clean up and module plots are in the appropriate order. If applicable, add a [MultiQC](https://https://multiqc.info/) module.
76+
10. Add a description of the output files and if relevant any appropriate images from the MultiQC report to `docs/output.md`.
77+
78+
### Default values
79+
80+
Parameters should be initialised / defined with default values within the `params` scope in `nextflow.config`.
81+
82+
Once there, use `nf-core pipelines schema build` to add to `nextflow_schema.json`.
83+
84+
### Default processes resource requirements
85+
86+
Sensible defaults for process resource requirements (CPUs / memory / time) for a process should be defined in `conf/base.config`. These should generally be specified generic with `withLabel:` selectors so they can be shared across multiple processes/steps of the pipeline. A nf-core standard set of labels that should be followed where possible can be seen in the [nf-core pipeline template](https://github.com/nf-core/tools/blob/main/nf_core/pipeline-template/conf/base.config), which has the default process as a single core-process, and then different levels of multi-core configurations for increasingly large memory requirements defined with standardised labels.
87+
88+
The process resources can be passed on to the tool dynamically within the process with the `${task.cpus}` and `${task.memory}` variables in the `script:` block.
89+
90+
### Naming schemes
91+
92+
Please use the following naming schemes, to make it easy to understand what is going where.
93+
94+
- initial process channel: `ch_output_from_<process>`
95+
- intermediate and terminal channels: `ch_<previousprocess>_for_<nextprocess>`
96+
97+
### Nextflow version bumping
98+
99+
If you are using a new feature from core Nextflow, you may bump the minimum required version of nextflow in the pipeline with: `nf-core pipelines bump-version --nextflow . [min-nf-version]`
100+
101+
### Images and figures
102+
103+
For overview images and other documents we follow the nf-core [style guidelines and examples](https://nf-co.re/developers/design_guidelines).
104+
105+
## GitHub Codespaces
106+
107+
This repo includes a devcontainer configuration which will create a GitHub Codespaces for Nextflow development! This is an online developer environment that runs in your browser, complete with VSCode and a terminal.
108+
109+
To get started:
110+
111+
- Open the repo in [Codespaces](https://github.com/maxulysse/compile-latex/codespaces)
112+
- Tools installed
113+
- nf-core
114+
- Nextflow
115+
116+
Devcontainer specs:
117+
118+
- [DevContainer config](.devcontainer/devcontainer.json)
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
name: Bug report
2+
description: Report something that is broken or incorrect
3+
labels: bug
4+
body:
5+
- type: textarea
6+
id: description
7+
attributes:
8+
label: Description of the bug
9+
description: A clear and concise description of what the bug is.
10+
validations:
11+
required: true
12+
13+
- type: textarea
14+
id: command_used
15+
attributes:
16+
label: Command used and terminal output
17+
description: Steps to reproduce the behaviour. Please paste the command you used to launch the pipeline and the output from your terminal.
18+
render: console
19+
placeholder: |
20+
$ nextflow run ...
21+
22+
Some output where something broke
23+
24+
- type: textarea
25+
id: files
26+
attributes:
27+
label: Relevant files
28+
description: |
29+
Please drag and drop the relevant files here. Create a `.zip` archive if the extension is not allowed.
30+
Your verbose log file `.nextflow.log` is often useful _(this is a hidden file in the directory where you launched the pipeline)_ as well as custom Nextflow configuration files.
31+
32+
- type: textarea
33+
id: system
34+
attributes:
35+
label: System information
36+
description: |
37+
* Nextflow version _(eg. 23.04.0)_
38+
* Hardware _(eg. HPC, Desktop, Cloud)_
39+
* Executor _(eg. slurm, local, awsbatch)_
40+
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter, Charliecloud, or Apptainer)_
41+
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
42+
* Version of maxulysse/compile-latex _(eg. 1.1, 1.5, 1.8.2)_
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
name: Feature request
2+
description: Suggest an idea for the maxulysse/compile-latex pipeline
3+
labels: enhancement
4+
body:
5+
- type: textarea
6+
id: description
7+
attributes:
8+
label: Description of feature
9+
description: Please describe your suggestion for a new feature. It might help to describe a problem or use case, plus any alternatives that you have considered.
10+
validations:
11+
required: true

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
<!--
2+
# maxulysse/compile-latex pull request
3+
4+
Many thanks for contributing to maxulysse/compile-latex!
5+
6+
Please fill in the appropriate checklist below (delete whatever is not relevant).
7+
These are the most common things requested on pull requests (PRs).
8+
9+
Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release.
10+
11+
Learn more about contributing: [CONTRIBUTING.md](https://github.com/maxulysse/compile-latex/tree/master/.github/CONTRIBUTING.md)
12+
-->
13+
14+
## PR checklist
15+
16+
- [ ] This comment contains a description of changes (with reason).
17+
- [ ] If you've fixed a bug or added code that should be tested, add tests!
18+
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/maxulysse/compile-latex/tree/master/.github/CONTRIBUTING.md)
19+
- [ ] Make sure your code lints (`nf-core pipelines lint`).
20+
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
21+
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
22+
- [ ] Usage Documentation in `docs/usage.md` is updated.
23+
- [ ] Output Documentation in `docs/output.md` is updated.
24+
- [ ] `CHANGELOG.md` is updated.
25+
- [ ] `README.md` is updated (including new tool citations and authors/contributors).
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
name: "Get number of shards"
2+
description: "Get the number of nf-test shards for the current CI job"
3+
inputs:
4+
max_shards:
5+
description: "Maximum number of shards allowed"
6+
required: true
7+
paths:
8+
description: "Component paths to test"
9+
required: false
10+
tags:
11+
description: "Tags to pass as argument for nf-test --tag parameter"
12+
required: false
13+
outputs:
14+
shard:
15+
description: "Array of shard numbers"
16+
value: ${{ steps.shards.outputs.shard }}
17+
total_shards:
18+
description: "Total number of shards"
19+
value: ${{ steps.shards.outputs.total_shards }}
20+
runs:
21+
using: "composite"
22+
steps:
23+
- name: Install nf-test
24+
uses: nf-core/setup-nf-test@v1
25+
with:
26+
version: ${{ env.NFT_VER }}
27+
- name: Get number of shards
28+
id: shards
29+
shell: bash
30+
run: |
31+
# Run nf-test with dynamic parameter
32+
nftest_output=$(nf-test test \
33+
--profile +docker \
34+
$(if [ -n "${{ inputs.tags }}" ]; then echo "--tag ${{ inputs.tags }}"; fi) \
35+
--dry-run \
36+
--ci \
37+
--changed-since HEAD^) || {
38+
echo "nf-test command failed with exit code $?"
39+
echo "Full output: $nftest_output"
40+
exit 1
41+
}
42+
echo "nf-test dry-run output: $nftest_output"
43+
44+
# Default values for shard and total_shards
45+
shard="[]"
46+
total_shards=0
47+
48+
# Check if there are related tests
49+
if echo "$nftest_output" | grep -q 'No tests to execute'; then
50+
echo "No related tests found."
51+
else
52+
# Extract the number of related tests
53+
number_of_shards=$(echo "$nftest_output" | sed -n 's|.*Executed \([0-9]*\) tests.*|\1|p')
54+
if [[ -n "$number_of_shards" && "$number_of_shards" -gt 0 ]]; then
55+
shards_to_run=$(( $number_of_shards < ${{ inputs.max_shards }} ? $number_of_shards : ${{ inputs.max_shards }} ))
56+
shard=$(seq 1 "$shards_to_run" | jq -R . | jq -c -s .)
57+
total_shards="$shards_to_run"
58+
else
59+
echo "Unexpected output format. Falling back to default values."
60+
fi
61+
fi
62+
63+
# Write to GitHub Actions outputs
64+
echo "shard=$shard" >> $GITHUB_OUTPUT
65+
echo "total_shards=$total_shards" >> $GITHUB_OUTPUT
66+
67+
# Debugging output
68+
echo "Final shard array: $shard"
69+
echo "Total number of shards: $total_shards"

0 commit comments

Comments
 (0)