-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use different styling options for clear_button and clear_tag_button #75
Comments
It seems like this choice was made on purpose, but I'm not sure I understand why: a054017 Should it not be possible to override the styling for |
That's because the button to clear the tag is only used in So there's no chance of them colliding if your LiveSeelct doesn't dynamically switch between tags to single mode. |
Aha, I see. The reason why I am trying to override both buttons at the same time, is because I've created a component as suggested here and wanted to apply all my custom branded styling in one place. If I understand you correctly, if I want the |
Yes, at the moment this is what you should do. A component for multiple selection and one for single selection. I can see however how this choice of reusing the same name for different styling options is a bit lazy and can lead to confusion. We should change this. I'll change the name of this issue accordingly, thanks |
Feel free to write PR for this if you feel like it @Munksgaard ! |
According to the documentation,
clear_tag_button
uses theclear_button_class
andclear_button_extra_class
to override and extend the styling. However, The default classes forclear_button
andclear_tag_button
are different, meaning that if I attempt to override the class of one, the other will inadvertently also be overwritten. Here are what the docs currently look like:I would expect
clear_tag_button
to useclear_tag_button_class
andclear_tag_button_extra_class
instead, but I get an error if I try to use those.The text was updated successfully, but these errors were encountered: