-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: Missing Monsters/NPCs #46
Comments
Thank you very much @imgurbot12 for delivering quality content for the repository! Much appreciated 🙏 Everytime I want to get back to the project for refinements I am halted by work and life. If you could please do a PR with the updated creatures.json I will happily merge it. To avoid having to constaly update the JSON dataset I was exploring the possibility to schedule a github action to perform the scrape. I'm not sure if this would break some github tos and anyway I'm not that much proficent with GH actions. I'm pinning the issue for the foreseeable future until a proper automated way to update the dataset is developed. |
@maxiride more than happy to, thanks! Just submitted a PR as requested. Can't say I know anything about GH Actions unfortunately so I'm not likely to be any help in that regard, but you're obviously welcome to do whatever you like with the script. |
@maxiride, is there any chance we can copy the new updated version in master to the gh-pages version please? I've noticed the website isn't using the new data as of yet which means I still have to run my own local instance. Would love to be able to use the public one if possible. Thanks! |
gh-pages branch updated! |
Original implementation issue maxiride#46
Hello! Love this project and I'm sad to see it hasn't been updated in a while, but I managed a pseudo-hotfix to include all of the most recent monsters/npcs if anyone is interested.
I wrote this quick python script to scrape the contents from aonprd's elasticsearch instance by reverse engineering their api-calls. It should hopefully generate a complete manifest of all available monsters/npcs. Hope it's useful for future updates in regards to fixing the current scraper implementation and helpful to anyone using this project in the future.
For any users, the generated
creatures.json
file just needs to be placed withinsrc/webui/public/
folder.The output could potentially just be added to the existing gh-pages site in order to include all of the current existing content.
Edit: a few quality of life changes like sorting the sets once back into a list and making NPCs a different creature-type
The text was updated successfully, but these errors were encountered: