Enable ssl in curl #2453
Merged
Enable ssl in curl #2453
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
curl-add-ssl
branch
2 times, most recently
from
8510033
to
73de4b1
Compare
JonasVautherin
commented
Nov 28, 2024
| "-DCURL_USE_LIBSSH2=OFF" | ||
| "-DBUILD_CURL_EXE=OFF" |
There was a problem hiding this comment.
I don't see a need to disable that only for Android and iOS, and disabling it pushes the need for dlopen to the build step, which is convenient.
JonasVautherin
force-pushed
the
curl-add-ssl
branch
2 times, most recently
from
e753e90
to
5626712
Compare
JonasVautherin
force-pushed
the
curl-add-ssl
branch
2 times, most recently
from
ceb7942
to
006ffd2
Compare
JonasVautherin
force-pushed
the
curl-add-ssl
branch
from
1afdb21
to
00a7abc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve mavlink/MAVSDK-Java#192.
Note: when using openssl, it seems like curl needs
dlopen: https://github.com/curl/curl/blame/a72b479decd555c9e9c2c50ded34e317123174f2/packages/vms/report_openssl_version.c#L54. We already add${CMAKE_DL_LIBS}to themavsdk_serverandunit_tests_mavsdk_servertargets but notintegration_tests,system_tests_runnerandunit_tests_runner. I think it makes sense to add it to libmavsdk as PUBLIC so that it gets propagated everywhere.