adding (void) to a few functions to match the protos

mention lack of INSTR

Author: maurymarkowitz

doc/TODO

@@ -9,6 +9,8 @@ WB = Wang BASIC
 PA = Palo Alto Tiny BASIC
 BP - DEC BASIC-PLUS
 
+- add INSTR and variations thereof
+
 - need to allow multiple INPUTs on a single line, currently it requires a CR between values
 
 - test and error on incorrect nesting of FOR loops, which we currently ignore

src/list.c

@@ -24,7 +24,7 @@ Boston, MA 02111-1307, USA.  */
  * Creates an empty list node. Private method.
  */
 list_t* _lst_alloc(void);
-list_t* _lst_alloc() {
+list_t* _lst_alloc(void) {
   list_t *node = (list_t *)malloc(sizeof(list_t));
   if (node == NULL)
     return NULL;

src/retrobasic.c

@@ -523,7 +523,7 @@ static char* number_to_hex_string(const double d)
 }
 
 /* number of jiffies since program start (or reset) 1/60th in Commodore/Atari format */
-static int elapsed_jiffies() {
+static int elapsed_jiffies(void) {
 	struct timeval current_time, elapsed_time, reset_delta;
 
 	// get the delta between the original start time and the reset time (likely zero)
@@ -2167,8 +2167,10 @@ static void perform_statement(list_t *statement_entry)
         if (statement->parms.generic_parameter != NULL) {
           value_t message = evaluate_expression(statement->parms.generic_parameter);
           printf("STOP: %s\n", message.string);
+        } else {
+          printf("STOPped at line: %d\n", current_line());
         }
-        exit(0);
+        exit(EXIT_SUCCESS);
       }
         break;
 
@@ -2227,7 +2229,7 @@ static void perform_statement(list_t *statement_entry)
 
       default:
         printf("Unimplemented statement %d\n", statement->type);
-				exit(0);
+				exit(EXIT_FAILURE);
     } //end switch
   }
 }
@@ -2257,20 +2259,20 @@ static void print_symbol(void *key, void *value, void *unused)
 //  return FALSE;
 //}
 /* used for VARLIST in those versions of BASIC that support it */
-static void print_variables() {
+static void print_variables(void) {
 	lst_foreach(interpreter_state.variable_values, print_symbol, NULL);
   printf("\n\n");
 }
 /* used for CLEAR, NEW and similar instructions. */
-static void delete_variables() {
+static void delete_variables(void) {
 	lst_free_everything(interpreter_state.variable_values);
 	interpreter_state.variable_values = NULL;
 }
-static void delete_functions() {
+static void delete_functions(void) {
 	lst_free_everything(interpreter_state.functions);
 	interpreter_state.functions = NULL;
 }
-static void delete_lines() {
+static void delete_lines(void) {
   for(int i = MAXLINE - 1; i >= 0; i--) {
     if (interpreter_state.lines[i] != NULL) {
       lst_free(interpreter_state.lines[i]);
@@ -2279,7 +2281,7 @@ static void delete_lines() {
 }
 
 /* set up empty trees to store variables and user functions as we find them */
-void interpreter_setup()
+void interpreter_setup(void)
 {
 	interpreter_state.variable_values = NULL;
 	interpreter_state.functions = NULL;

src/scan.l

@@ -131,13 +131,11 @@ SUBSTRING\$  { return SUBSTR; }
  /* system functions */
 TAB			  { return TAB; }
 SPC			  { return SPC; }
-PEEK      { return PEEK; } // also EXAM (North Star) and FETCH (Digital Group Opus)
+SPA       { return SPC; }   // from HP, same as SPC
+PEEK      { return PEEK; }  // also EXAM (North Star) and FETCH (Digital Group Opus)
 FRE       { return FRE; }
 USR       { return USR; }
 LIN       { return LIN; }
- /* aliases for SPC */
-SPA       { return SPC; } // from HP, same as above
-SPACE\$   { return SPC; } // returns a string with spaces, doesn't just output it, but we allow assignment anyway so this works
 
  /* various operators and punctuation */
 [:,;()\[\]\^=+\-*/\<\>\&]     { return yytext[0]; }
@@ -173,6 +171,7 @@ CONVERT   { return CONVERT; }
 UCASE\$   { return UCASE; }
 LCASE\$   { return LCASE; }
 STRING\$  { return STRNG; } // returns n copies of a given string
+SPACE\$   { return SPC; }   // returns n spaces as a value, which is how our SPC works anyway
 
  /* commodore-style TIME and TIME$ */
 TIME\$  { return TIME_STR; }

src/statistics.c

@@ -102,7 +102,7 @@ static void is_integer(void *key, void *value, void *user_data)
 
 /* prints out various statistics from the static code,
  or if the write_stats flag is on, writes them to a file */
-void print_statistics()
+void print_statistics(void)
 {
   int lines_total = 0, line_min = MAXLINE + 1, line_max = -1;
   double linenum_1_digit = 0.0, linenum_2_digit = 0.0, linenum_3_digit = 0.0, linenum_4_digit = 0.0, linenum_5_digit = 0.0;