This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Added a max_duration parameter to __construct() and some code at do_d… #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etect_greedy_big_to_small() in order to abort the face detection after x seconds and to prevent the process from an endless loop. Signed-off-by: NEPOMUC.com <[email protected]>
|
I'm not sure adding a timeout is a good strategy. It would be better to fix the infinite loop. |
|
@mauricesvay Thanks for you feedback! My "solution" with the timeout is already six years old. I only created the pull request a few days ago, because I thought it might be helpful. I totally understand your concerns and you're right: It's not a real fix. For me it worked out fine as a quick workaround and ensure control over execution time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etect_greedy_big_to_small() in order to abort the face detection after x seconds and to prevent the process from an endless loop.
Signed-off-by: NEPOMUC.com [email protected]