Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong indirectly_writable parameter? #94

Open
danieltowner opened this issue Jun 22, 2023 · 1 comment
Open

Wrong indirectly_writable parameter? #94

danieltowner opened this issue Jun 22, 2023 · 1 comment
Assignees

Comments

@danieltowner
Copy link
Collaborator

In copy_to, the constraint is indirectly_writable<value_type>, but should it actually be indirectly_writable<iter_value_t<Out>>? It seems like it should be checking that the output can be written to as the type of the iterator, without any complications arising from a conversion too.

@mattkretz
Copy link
Owner

My intent was to also constrain on the conversion being well-formed. Why would we ever want to allow a converting store that doesn't allow the conversion? Ah... when value_type isn't implicitly convertible to iter_value_t<Out>, a static_cast is well-formed and simdflags_convert was used?

@mattkretz mattkretz self-assigned this Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Undecided
Development

No branches or pull requests

2 participants