Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this be used in ROS 2? #10

Open
heiyumiao opened this issue Aug 9, 2023 · 4 comments
Open

Can this be used in ROS 2? #10

heiyumiao opened this issue Aug 9, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@heiyumiao
Copy link

Or what modifications do I need to make if I want to use it in ROS2

@matthias-mayr
Copy link
Owner

Good question. I haven't looked into ROS 2 control yet. Since the control algorithms are abstracted in a base class, these do not need to be touched. The ROS 1 integration is already a wrapper around them, so it might be comparably easy to make this ROS 2 compliant.

If you have the time to look into it, you can take a look at the cartesian_controllers library that already did the ROS 2 port.
A pull request would definitely appreciated. Unfortunately I would not have time to look into a ROS 2 port in the next months myself.

@student-0103
Copy link

any update on this one?

@matthias-mayr
Copy link
Owner

I learned a bit more about ros2_control in the meantime and it should be relatively to port this package.
However, I am afraid that I will not have any time myself to do this before February.

If anyone is interested in doing this and to send in a pull request, that would be greatly appreciated.

@mhubii
Copy link

mhubii commented Mar 25, 2024

agreed, since the code is nicely structured, this shouldn't be too difficult. Might give this a go, but currently busy doing other things as well. For reference lbr-stack/lbr_fri_ros2_stack#163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants