Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5.0 compatibility #205

Open
taraspasichnyk opened this issue Mar 27, 2019 · 8 comments
Open

Swift 5.0 compatibility #205

taraspasichnyk opened this issue Mar 27, 2019 · 8 comments

Comments

@taraspasichnyk
Copy link

Are you planning to update codebase?

@MayankAgarwal04
Copy link

MayankAgarwal04 commented Mar 29, 2019

Hi Team,

I am having a trouble loading the keychain data. App crash when loadDataForUserAccount is called. Mac OS 10.14.4 and Xcode 10.2

When you guys are planning to update codebase. @matthewpalmer @victor @jonallured @hermanolsson @jakemarsh @diejmon @marcelofabri @edwellbrook @larslockefeer

@mromanuk
Copy link

mromanuk commented Apr 4, 2019

updated Xcode and it converted my codebase to Swift 5.0 compulsively 😫.
Now I need Locksmith in 5.0 😤

@mromanuk
Copy link

mromanuk commented Apr 4, 2019

Just submitted a Pull Request to address this, hope some of the admins see it

@pableiros
Copy link

Is this repository deprecated?

@lohithkorp
Copy link

same issue for me too. any solution please?

@lohithkorp
Copy link

my issue is same as @MayankAgarwal04
Trouble loading the keychain data. App crash when loadDataForUserAccount is called.
Mac OS 10.14.4 and Xcode 10.2 - Swift 5

@mromanuk
Copy link

mromanuk commented May 31, 2019

sorry, I messed up, my comment was for a different project.

  1. Use it with PR
  2. use my fork
  3. download it yourself and put Swift 5.0 instead of 4.x

EDIT: I'm using my own fork, which just address the flag that it should compile with Swift 5.0 (it works)

@abdullah-s
Copy link

swift 5 upgraded, all tests passed
check this out
https://github.com/stephanheilner/Locksmith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants