Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert icons component in images folder to typescript #437

Open
ayusht2810 opened this issue Jan 9, 2024 · 3 comments
Open

Convert icons component in images folder to typescript #437

ayusht2810 opened this issue Jan 9, 2024 · 3 comments
Assignees
Labels
Help Wanted Community help wanted Typescript Migration Issues that requires typescript migration

Comments

@ayusht2810
Copy link
Contributor

We plan to migrate the gitlab plugin webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify the above mentioned file and associate test files (if the file exists).

Below is a checklist of items you should be doing to migrate:

  • Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx).
  • Add relevant types in the component(s) code.
  • Update any components using those to the correct imports.
  • Fix any errors generated by the TypeScript compiler. You can run rpm run check-types to display any errors.
    We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.

Some examples of already migrated files can be found here:

@ayusht2810 ayusht2810 added Help Wanted Community help wanted Typescript Migration Issues that requires typescript migration labels Jan 9, 2024
@Willy-Wakam
Copy link
Contributor

Can I work on this?

@mickmister
Copy link
Contributor

Absolutely, thanks @Willy-Wakam!

@Kshitij-Katiyar
Copy link
Contributor

Hey @Willy-Wakam , Do you need any help from our side on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted Typescript Migration Issues that requires typescript migration
Projects
None yet
Development

No branches or pull requests

4 participants