Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement browser based login flow from desktop app #418

Open
bbodenmiller opened this issue Dec 1, 2023 · 3 comments
Open

Implement browser based login flow from desktop app #418

bbodenmiller opened this issue Dec 1, 2023 · 3 comments
Milestone
v1.10.0

Comments

@bbodenmiller
Copy link
Contributor

Desktop app now pops out to browser for OAuth for main Mattermost login. Any chance the same could be done with the GitLab integration login?

cc @devinbinnie
@mickmister mickmister mentioned this issue Dec 6, 2023
Merged
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.10.0 milestone Jul 16, 2024
@raghavaggarwal2308
Copy link
Contributor

Desktop app now pops out to browser for OAuth for main Mattermost login

@bbodenmiller Can you please provide some more details here?

@bbodenmiller
Copy link
Contributor Author

@raghavaggarwal2308 for Mattermost login if you select GitLab SSO option from Mattermost desktop app it pops you out to your web browser where you login to GitLab and then it jumps back to Mattermost Desktop app. It'd be helpful if GitLab plugin did the same. My understand is that this is the proper OAuth spec at this point rather than embedding login in the app.

@raghavaggarwal2308
Copy link
Contributor

@bbodenmiller Thank you for the details. We will look into the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
2 participants
@bbodenmiller @raghavaggarwal2308