Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow messages for *all* teams #36

Open
umlaeute opened this issue Mar 26, 2020 · 5 comments · May be fixed by #131
Open

allow messages for *all* teams #36

umlaeute opened this issue Mar 26, 2020 · 5 comments · May be fixed by #131
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@umlaeute
Copy link

currently we can specify a welcome-text for each team separately.

however, i would like to be able to send people a welcome-message after their first login - regardless of the team they join.

Probably the simplest solution (from a admin-pov) is to be able to omit the TeamName or use a wild-card.

E.g. the following would remind a user of the code-of-conduct the first time they log-in (the TeamName field has been omitted), and gives a welcome-message for each team they join (the TeamName is *):

"Plugins": {
    "com.mattermost.welcomebot": {
        "WelcomeMessages": [
            {
                "DelayInSeconds": 1,
                "Message": [
                    "### Welcome {{.UserDisplayName}}!",
                    "",
                    "Please check out our [Code-Of-Conduct](https://mm.example.com/coc/) before using MatterMost",
                ]
            },
            {
                "TeamName": "*",
                "DelayInSeconds": 5,
                "Message": [
                    "### Welcome {{.UserDisplayName}} to the {{.Team.DisplayName}} team!",
                    "",
                    "Feel free to discuss off-topic things, but please use the ~off-topic channel for this",
                ]
            }
    ]
  }
}
@levb levb added Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Apr 7, 2020
@levb
Copy link
Contributor

levb commented Apr 7, 2020

I 👍 the suggestion of defaulting to ALL (augmented by team-specific messages). @aaronrothschild are you good with it?

@hanzei hanzei added the Type/Enhancement New feature or improvement of existing feature label Apr 22, 2020
@hanzei
Copy link
Contributor

hanzei commented May 27, 2021

"" should mean ALL

@umlaeute
Copy link
Author

The good thing about "*" is, that it is consistent with other wildcard-uses.

i'm afraid that with a suggestion of "", the first one to pick up the implementation would implement exactly that, and nothing else. and the issue will be closed and not looked at again.

whereas if "*" gets implemented, you have a much more powerful tool at hand with little additional coding effort.

@hanzei
Copy link
Contributor

hanzei commented May 28, 2021

Good point on the regex support. Sound good to me 👍

@umlaeute
Copy link
Author

i was actually more thinking of globbing, but regex is fine for me as well :-)

@haardikdharma10 haardikdharma10 mentioned this issue May 30, 2021
Open
@maisnamrajusingh maisnamrajusingh mentioned this issue Jun 29, 2021
Closed
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 30, 2021
@hanzei hanzei linked a pull request Jun 30, 2021 that will close this issue
Allows using * to configure the welcome message for all teams #80
Closed
maisnamrajusingh added a commit to demansoltech/mattermost-plugin-welcomebot that referenced this issue Sep 2, 2021
@maisnamrajusingh
Merge branch 'master' into mattermost-communitygh-36
5d69afd
@ayusht2810 ayusht2810 linked a pull request Apr 17, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
5 participants
@umlaeute @jespino @levb @cpanato @hanzei