Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Commit ab1e866

Browse files
authored
fix: Expanded on "contributing to docs page" section : Doc - 87 (#161)
* expand collaboration page * update add-resources page * updated statement * updated c * updated issue template * updated contents * update to the resource page * re-structure contribution section * updated title
1 parent 1af249f commit ab1e866

File tree

8 files changed

+107
-52
lines changed

8 files changed

+107
-52
lines changed

ISSUE_TEMPLATE.md

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,38 @@
1+
<!-- Thanks for reporting an issue! Please fill out the blanks below. -->
2+
13
<!--- Provide a general summary of the issue in the Title above -->
24

3-
🧾 Expected Behaviour
5+
## 🧾 Expected Behaviour
46

5-
<!--- If you're describing a bug, tell us what should happen --><!--- If you're suggesting a change/improvement, tell us how it should work -->
7+
<!--- If you're describing an error, tell us what should happen --><!--- If you're suggesting a change/improvement, tell us how it should work -->
68

79
🔨 Current Behaviour
810

9-
<!--- If describing a bug, tell us what happens instead of the expected behaviour --><!--- If suggesting a change/improvement, explain the difference from current behaviour -->
11+
<!--- If describing an error in your integration, tell us what happens instead of the expected behaviour --><!--- If suggesting a change/improvement, explain the difference from current behaviour -->
1012

1113
## 🙋‍️ Possible Solution [optional]
1214

13-
<!--- Not obligatory, but suggest a fix/reason for the bug, --><!--- or ideas how to implement the addition or change -->
15+
....
16+
17+
<!--- Not obligatory, but suggest a fix/reason for the error, --><!--- or ideas on how to implement the addition or change -->
18+
19+
## 📝 Steps to Reproduce (for errors)
1420

15-
## 📝 Steps to Reproduce (for bugs)
21+
....
1622

17-
<!--- Provide a link to a live example, or an unambiguous set of steps to --><!--- reproduce this bug. Include code to reproduce, if relevant -->1.2.3.4.
23+
<!--- Provide a link to a live example or an unambiguous set of steps to --><!--- reproduce this bug. Include code to reproduce, if relevant -->1.2.3.4.
1824

19-
## 🖥 Context
25+
## 🖥 Context: What were you expecting to happen?
26+
27+
....
2028

2129
<!--- How has this issue affected you? What are you trying to accomplish? --><!--- Providing context helps us come up with a solution that is most useful in the real world -->
2230

31+
## ❌ Any logs, error output, etc?
32+
<!-- If it’s long, please paste to https://gist.github.com/ and insert the link here. -->
33+
34+
> Link to your issue / project:
35+
2336
## 🔩 Your Environment
2437

2538
<!--- Include as many relevant details about the environment you experienced the bug in -->
@@ -28,7 +41,10 @@
2841
* Browser Name and version:
2942
* Operating System and version (desktop or mobile):
3043

31-
> Link to your issue / project:
44+
## ✅ Acceptance criteria
3245

46+
....
3347

34-
## ✅ Acceptance criteria
48+
## Any other comments?
49+
50+
....

docs/.vuepress/config.js

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,11 @@ module.exports = {
7272
title: "Getting started",
7373
path: "/dev/fundamentals",
7474
collapsable: false,
75-
children: ["/dev/fundamentals/rollups.md", "/dev/fundamentals/zkSync.md", "/dev/fundamentals/testnet.md", "/dev/fundamentals/faq.md"],
75+
children: [
76+
"/dev/fundamentals/rollups.md",
77+
"/dev/fundamentals/zkSync.md",
78+
"/dev/fundamentals/testnet.md",
79+
"/dev/fundamentals/faq.md"],
7680
},
7781
{
7882
title: "Understanding zkSync",
@@ -108,7 +112,10 @@ module.exports = {
108112
title: "Tutorials",
109113
path: "/dev/tutorials",
110114
collapsable: false,
111-
children: ["/dev/tutorials/cross-chain-tutorial.md", "/dev/tutorials/custom-aa-tutorial.md", "/dev/tutorials/custom-paymaster-tutorial.md"],
115+
children: [
116+
"/dev/tutorials/cross-chain-tutorial.md",
117+
"/dev/tutorials/custom-aa-tutorial.md",
118+
"/dev/tutorials/custom-paymaster-tutorial.md"],
112119
},
113120
{
114121
title: "Troubleshooting",
@@ -118,7 +125,7 @@ module.exports = {
118125
"/dev/troubleshooting/important-links.md",
119126
"/dev/troubleshooting/status.md",
120127
"/dev/troubleshooting/docs-contribution/docs.md",
121-
"/dev/troubleshooting/docs-contribution/edit-doc.md",
128+
"/dev/troubleshooting/docs-contribution/community-resources.md",
122129
"/dev/troubleshooting/known-issues.md",
123130
],
124131
},
@@ -186,14 +193,21 @@ module.exports = {
186193
path: "/api/hardhat", // optional, which should be a absolute path.
187194
collapsable: false, // optional, defaults to true
188195
sidebarDepth: 1,
189-
children: ["/api/hardhat/getting-started", "/api/hardhat/plugins", "/api/hardhat/testing", "/api/hardhat/compiling-libraries"],
196+
children: [
197+
"/api/hardhat/getting-started",
198+
"/api/hardhat/plugins",
199+
"/api/hardhat/testing",
200+
"/api/hardhat/compiling-libraries"],
190201
},
191202
{
192203
title: "Block Explorer", // required
193204
path: "/api/tools/block-explorer", // optional, which should be a absolute path.
194205
collapsable: false, // optional, defaults to true
195206
sidebarDepth: 1, // optional, defaults to 1
196-
children: ["/api/tools/block-explorer/intro", "/api/tools/block-explorer/block-view", "/api/tools/block-explorer/contract-verification"],
207+
children: [
208+
"/api/tools/block-explorer/intro",
209+
"/api/tools/block-explorer/block-view",
210+
"/api/tools/block-explorer/contract-verification"],
197211
},
198212
],
199213
},

docs/dev/developer-guides/aa.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ The `zksync-web3` SDK provides [methods](../../api/js/utils.md#encoding-paymaste
297297

298298
### Testnet paymaster
299299

300-
To let users experience using with paymasters on testnet, as well as to keep supporting paying fees in ERC20 tokens, the Matter Labs team provides the testnet paymaster, that enables paying fees in ERC20 token at a 1:1 exchange rate with ETH (i.e. one unit of this token is equal to 1 wei of ETH).
300+
To ensure users experience paymasters on testnet, as well as keep supporting paying fees in ERC20 tokens, the Matter Labs team provides the testnet paymaster, that enables paying fees in ERC20 token at a 1:1 exchange rate with ETH (i.e. one unit of this token is equal to 1 wei of ETH).
301301

302302
The paymaster supports only the [approval based](#approval-based-paymaster-flow) paymaster flow and requires that the `token` param is equal to the token being swapped and `minAllowance` to equal to least `tx.maxFeePerErg * tx.ergsLimit`. In addition, the testnet paymaster does not make use of the `_innerInput` parameter, so nothing should be provided (empty `bytes`).
303303

docs/dev/troubleshooting/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@ Get brief explainers on your integration with zkSync.
77
- [Important links](./important-links.md)
88
- [Status](./status.md)
99
- [Known issues](./known-issues.md)
10-
- [Contribute to documentation](./docs-contribution/docs.md)
10+
- [Contribute to documentation](./docs-contribution/docs.md)
11+
- [Contribute to Awesome zkSync repo](./docs-contribution/community-resources.md)
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
## Community resources
2+
3+
We cannot promise to cover all aspects of zkSync so we will attempt to highlight some of the community's outstanding resources such as videos, tutorials, articles etc.
4+
5+
The [Awesome zkSync repo](https://github.com/0xJuancito/awesome-zksync) is where community-based resources live.
6+
7+
## Criteria for contributing
8+
To contribute to the Awesome zkSync repo, the following are some criteria to keep in mind:
9+
10+
- Is the content resource current?
11+
- Is the content resource protected by a payment wall?
12+
- Is the information trustworthy? Is it based on facts or opinions?
13+
- How reputable is the author? Do they cite their references?
14+
- Does the content resource provide anything new or different from what can be found in the documentation?
15+
## Making your contribution
16+
If you find a content resource related to the zkSync ecosystem, be free to recommend its addition to the *Awesome zkSync repo* by making a pull request.

docs/dev/troubleshooting/docs-contribution/docs.md

Lines changed: 44 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,47 @@ As collaboration on contribution to zkSync documentation is such an integral par
1111
- If you find a problem with a specific page in the zkSync documentation, you can always [edit the page](./edit-doc.md) to fix it.
1212
- If you want to discuss a larger problem or propose a major change to the zkSync documentation, you can raise an [issue on Github](https://github.com/matter-labs/zksync-web-v2-docs/issues).
1313
- Share views and know the latest discussions on our [Community Forum](https://community.zksync.io/).
14-
- Follow zkSync on Twitter to get the latest happenings on zkSync.
14+
- Follow zkSync on Twitter to get the latest happenings on zkSync.
15+
16+
## Ways to contribute
17+
18+
- [Create or edit a page](#edit-or-review-a-documentation-page) - Improve on the existing pages or create a new one.
19+
- [Pick an issue and work on it](https://github.com/matter-labs/zksync-web-v2-docs/issues) - Work on issues that's has been raised.
20+
- [Add community resources](./community-resources.md) - Help us add relevant resources, such as videos, tutorials or articles.
21+
22+
23+
## Edit or review a documentation page
24+
25+
### Goal
26+
Find a documentation page that you think needs updating, proofreading, or editing.
27+
28+
### Background and reference information
29+
30+
[Content style guide](https://www.notion.so/matterlabs/Communication-Strategy-a4836bd6d2254268b60a489d82992d71) - zkSync content style guide.
31+
32+
### Categories of contribution
33+
34+
Review the page, to see if it needs editing. Things to look for:
35+
1. Proofreading (spelling, grammar, punctuation).
36+
2. Does the particular page of interest follow the content style guide and the documentation structure guide, if it doesn't you can edit.
37+
3. 404 links - Make edits and create a PR to fix any broken links.
38+
4. Language translation - We will make a guide for you to follow if you want to translate zkSync documentation into a non-English language.
39+
40+
### Detailed steps
41+
42+
1. In the page of interest, click on `Edit this page`,
43+
2. Step 1 takes you to GitHub: either create an account on [GitHub](https://github.com/join), or if you already have an account, then sign in.
44+
3. Click on the pen icon to fork the repo so you can start contributing to the documentation.
45+
![fork-repo](https://user-images.githubusercontent.com/55744578/136702921-3105350a-a68a-4aa4-8c5d-fb24742652b2.jpg)
46+
4. Edit MD files:
47+
- We use markdown in the documentation, you will need to know markdown to be able to contribute to the docs.
48+
- Make edits to the files after forking the repo and preview your changes. If you have not read our [content style guide](https://www.notion.so/matterlabs/Communication-Strategy-a4836bd6d2254268b60a489d82992d71), please do before you begin this step.
49+
5. Write a brief description of the changes you made and click on `Propose Changes`.
50+
6. After editing the files click on `Create pull request` and wait for our reviewers to review your PR.
51+
![create-pull-request](https://user-images.githubusercontent.com/55744578/136703597-6644e43c-7c64-4cc0-bf8b-7fb8db9544cf.jpg)
52+
53+
54+
### Learning/Improvement resources:
55+
56+
- [Technical Writing Best Practices](https://proedit.com/technical-writing-best-practices/).
57+
- [9 Technical Writing Tips Every Writer Needs to Know](https://www.instructionalsolutions.com/blog/technical-writing-tips).

docs/dev/troubleshooting/docs-contribution/edit-doc.md

Lines changed: 0 additions & 35 deletions
This file was deleted.

docs/dev/troubleshooting/edit-doc.md

Whitespace-only changes.

0 commit comments

Comments
 (0)