Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting doesn't seem to work right #39

Open
meichthys opened this issue Feb 22, 2024 · 10 comments
Open

Sorting doesn't seem to work right #39

meichthys opened this issue Feb 22, 2024 · 10 comments

Comments

@meichthys
Copy link
Contributor

meichthys commented Feb 22, 2024

Some of the accounts seem to be sorted correctly, but any new accounts i add are not and seem to just remain at the bottom of the list.

Name sorted A > Z:
image

Name sorted Z > A:
image

Issuer Sorted A > Z:
image

Issuer Sorted Z > A:
image

@meichthys meichthys changed the title Web sorting doesn't seem to work right Sorting doesn't seem to work right Feb 22, 2024
@matteo-convertino
Copy link
Owner

Do you mean when you use automatic sorting on the mobile app and then view it on the nextcloud extension?

@meichthys
Copy link
Contributor Author

No, not really.
All the accounts have bees added and managed/viewed through the mobile app.

@matteo-convertino
Copy link
Owner

I returned to this issue. Sorry when I first read it I didn't notice this:

but any new accounts i add are not and seem to just remain at the bottom of the list.

Premise: the automatic sorting feature is only on the mobile app, the nextcloud extension is only "passive" from this point of view. Also because to make the sorting "global" (therefore applicable on all devices) this option should be synchronized, as happens for accounts. At the moment, however, I see it as a job that can take a back seat.

Actually, for now on the mobile app no automatic sorting is applied during account creation, so it is "right" that this happens.
I could fix it but only on the mobile app, so when you add a new account from the mobile app it gets sorted automatically. But if you create a new account from the webapp you will still have the same result.

@meichthys
Copy link
Contributor Author

I don't think synchronization is necessary, but if you click the header columns in the nextcloud extension, or sort in the mobile, app, you should be able to see the accounts in order. Currently the accounts just don't sort.

@meichthys
Copy link
Contributor Author

Perhaps this was fixed in one of the newer releases, but I'm not seeing it because I'm stuck on v 0.4 still due to lingering issues with #42 which prevents us from upgrading to 0.5.3

@matteo-convertino
Copy link
Owner

Perhaps this was fixed in one of the newer releases, but I'm not seeing it because I'm stuck on v 0.4 still due to lingering issues with #42 which prevents us from upgrading to 0.5.3

This error should be resolved by now and you should be able to update without problems, in fact I invite you to let me know if this is not the case for you. You can continue writing on that issue if you want.

@meichthys
Copy link
Contributor Author

Thanks! I was able to do a full wipe and re-install with v0.5.3. I had tried this in the past but, when i tried to re-import using a non-encrpyted json file it was hanging and giving the spinning wheel at "checking password" step. I re-wiped everything and re-installed and imported using the encrypted json file and that worked flawlessly 👍

@meichthys
Copy link
Contributor Author

Just to follow up on the original issue, It does look like the sorting is still affected in v0.5.3.

@matteo-convertino
Copy link
Owner

I don't think synchronization is necessary, but if you click the header columns in the nextcloud extension, or sort in the mobile, app, you should be able to see the accounts in order. Currently the accounts just don't sort.

Sorry for the stupid question, could you explicitly tell me the steps you take to have this problem?
I'm asking because I honestly can't replicate it.

@meichthys
Copy link
Contributor Author

meichthys commented Apr 24, 2024

I've basically just been adding accounts like normal using the Android mobile app (downloaded from github). Newly added accounts appear at the bottom of the list of accounts despite sorting from A>Z or Z>A.
The order of other accounts do change, and some of the newly added accounts do seem to reorder, but the order doesn't make any rational sense. It looks like it could be that when i sort by "issuer", it is actually sorting by the Account # that is shown in the web interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants