Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for validation split as attribute of every Data object. #152

Open
jgallowa07 opened this issue Apr 1, 2024 · 0 comments
Open

Allow for validation split as attribute of every Data object. #152

jgallowa07 opened this issue Apr 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jgallowa07
Copy link
Member

The way in which we perform cross validation now, is quite slow as we must; convert mutations to be with respect to the reference sequence, build the one-hot matrix, and finally compile the predictive function before making predictions. One thing that would drastically speed things up (and simplify the interface / source code) would be to add the option to split the full dataset at the time of Data initialization (the place to do that would be here). Then, getting validation loss would be as simple and fast as getting loss - and then it would be trivial to get conditional loss.

@jgallowa07 jgallowa07 added the enhancement New feature or request label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant