feat: Remove experimental flags for IVF and FullText indexes main (#23175)

This PR removes the control logic for experimental_ivf_index and experimental_fulltext_index. Both features are now always enabled.

Approved by: @ouyuanning, @heni02

Author: XuPeng-SH

pkg/sql/compile/ddl.go

@@ -2062,12 +2062,6 @@ func (s *Scope) handleVectorIvfFlatIndex(
 	originalTableDef *plan.TableDef,
 	indexInfo *plan.CreateTable,
 ) error {
-	if ok, err := s.isExperimentalEnabled(c, ivfFlatIndexFlag); err != nil {
-		return err
-	} else if !ok {
-		return moerr.NewInternalErrorNoCtx("IVF index is not enabled")
-	}
-
 	// 1. static check
 	if len(indexDefs) != 3 {
 		return moerr.NewInternalErrorNoCtx("invalid ivf index table definition")

pkg/sql/compile/ddl_index_algo.go

@@ -34,9 +34,7 @@ import (
 )
 
 const (
-	ivfFlatIndexFlag  = "experimental_ivf_index"
-	fulltextIndexFlag = "experimental_fulltext_index"
-	hnswIndexFlag     = "experimental_hnsw_index"
+	hnswIndexFlag = "experimental_hnsw_index"
 )
 
 func (s *Scope) handleUniqueIndexTable(
@@ -135,12 +133,6 @@ func (s *Scope) handleFullTextIndexTable(
 	originalTableDef *plan.TableDef,
 	indexInfo *plan.CreateTable,
 ) (err error) {
-	if ok, err := s.isExperimentalEnabled(c, fulltextIndexFlag); err != nil {
-		return err
-	} else if !ok {
-		return moerr.NewInternalErrorNoCtx("FullText index is not enabled")
-	}
-
 	// create hidden tables
 	if indexInfo != nil {
 		if len(indexInfo.GetIndexTables()) != 1 {
@@ -476,10 +468,9 @@ func (s *Scope) logTimestamp(c *Compile, qryDatabase, metadataTableName, metrics
 }
 
 func (s *Scope) isExperimentalEnabled(c *Compile, flag string) (bool, error) {
-
 	if s.Magic == TableClone {
 		skipFlags := []string{
-			fulltextIndexFlag, ivfFlatIndexFlag, hnswIndexFlag,
+			hnswIndexFlag,
 		}
 
 		// if the scope is a table clone means we are trying to

pkg/sql/compile/ddl_test.go

@@ -780,15 +780,7 @@ func TestPitrDupError(t *testing.T) {
 func TestIsExperimentalEnabled(t *testing.T) {
 	s := newScope(TableClone)
 
-	enabled, err := s.isExperimentalEnabled(nil, fulltextIndexFlag)
-	assert.NoError(t, err)
-	assert.True(t, enabled)
-
-	enabled, err = s.isExperimentalEnabled(nil, ivfFlatIndexFlag)
-	assert.NoError(t, err)
-	assert.True(t, enabled)
-
-	enabled, err = s.isExperimentalEnabled(nil, hnswIndexFlag)
+	enabled, err := s.isExperimentalEnabled(nil, hnswIndexFlag)
 	assert.NoError(t, err)
 	assert.True(t, enabled)
 }

pkg/sql/compile/util.go

@@ -425,19 +425,12 @@ func (s *Scope) checkTableWithValidIndexes(c *Compile, relation engine.Relation)
 		if idxdef, ok := constraint.(*engine.IndexDef); ok && len(idxdef.Indexes) > 0 {
 			for _, idx := range idxdef.Indexes {
 				if idx.TableExist {
-					var indexflag string
+					// Only check hnswIndexFlag
 					if catalog.IsHnswIndexAlgo(idx.IndexAlgo) {
-						indexflag = hnswIndexFlag
-					} else if catalog.IsIvfIndexAlgo(idx.IndexAlgo) {
-						indexflag = ivfFlatIndexFlag
-					} else if catalog.IsFullTextIndexAlgo(idx.IndexAlgo) {
-						indexflag = fulltextIndexFlag
-					}
-
-					if len(indexflag) > 0 {
+						indexflag := hnswIndexFlag
 						if ok, err := s.isExperimentalEnabled(c, indexflag); err != nil {
 							return err
-						} else if !ok && !c.ignoreCheckExperimental {
+						} else if !ok {
 							return moerr.NewInternalError(c.proc.Ctx, fmt.Sprintf("%s is not enabled", indexflag))
 						}
 					}

test/distributed/cases/array/array_index.result

@@ -1,4 +1,3 @@
-SET experimental_ivf_index = 1;
 drop database if exists vecdb2;
 create database vecdb2;
 use vecdb2;
@@ -658,5 +657,4 @@ count(*)
 select count(*) from mo_catalog.mo_tables where reldatabase = "vecdb3"; -- rag_table + 0 ivf index tables
 count(*)
 1
-SET experimental_ivf_index = 0;
 drop database vecdb3;

test/distributed/cases/array/array_index.sql

@@ -1,5 +1,3 @@
-SET experimental_ivf_index = 1;
-
 -- pre
 drop database if exists vecdb2;
 create database vecdb2;
@@ -719,5 +717,4 @@ select count(*) from mo_catalog.mo_indexes as i join mo_catalog.mo_tables as t o
 
 select count(*) from mo_catalog.mo_tables where reldatabase = "vecdb3"; -- rag_table + 0 ivf index tables
 
-SET experimental_ivf_index = 0;
 drop database vecdb3;

test/distributed/cases/array/array_index_1.result

@@ -1,4 +1,3 @@
-SET experimental_ivf_index = 1;
 drop database if exists vecdb2;
 create database vecdb2;
 use vecdb2;
@@ -634,5 +633,4 @@ a    b    c    d
 9776    [10, 3, 8, 5, 48, 26, 5, 16, 17, 0, 0, 2, 132, 53, 1, 16, 112, 6, 0, 0, 7, 2, 1, 48, 48, 15, 18, 31, 3, 0, 0, 9, 6, 10, 19, 27, 50, 46, 17, 9, 18, 1, 4, 48, 132, 23, 3, 5, 132, 9, 4, 3, 11, 0, 2, 46, 84, 12, 10, 10, 1, 0, 12, 76, 26, 22, 16, 26, 35, 15, 3, 16, 15, 1, 51, 132, 125, 8, 1, 2, 132, 51, 67, 91, 8, 0, 0, 30, 126, 39, 32, 38, 4, 0, 1, 12, 24, 2, 2, 2, 4, 7, 2, 19, 93, 19, 70, 92, 2, 3, 1, 21, 36, 58, 132, 94, 0, 0, 0, 0, 21, 25, 57, 48, 1, 0, 0, 1]    3    [0, 0, 0]
 9777    [16, 15, 0, 0, 5, 46, 5, 5, 4, 0, 0, 0, 28, 118, 12, 5, 75, 44, 5, 0, 6, 32, 6, 49, 41, 74, 9, 1, 0, 0, 0, 9, 1, 9, 16, 41, 71, 80, 3, 0, 0, 4, 3, 5, 51, 106, 11, 3, 112, 28, 13, 1, 4, 8, 3, 104, 118, 14, 1, 1, 0, 0, 0, 88, 3, 27, 46, 118, 108, 49, 2, 0, 1, 46, 118, 118, 27, 12, 0, 0, 33, 118, 118, 8, 0, 0, 0, 4, 118, 95, 40, 0, 0, 0, 1, 11, 27, 38, 12, 12, 18, 29, 3, 2, 13, 30, 94, 78, 30, 19, 9, 3, 31, 45, 70, 42, 15, 1, 3, 12, 14, 22, 16, 2, 3, 17, 24, 13]    4    [0, 0, 0]
 9778    [41, 0, 0, 7, 1, 1, 20, 67, 9, 0, 0, 0, 0, 31, 120, 61, 25, 0, 0, 0, 0, 10, 120, 90, 32, 0, 0, 1, 13, 11, 22, 50, 4, 0, 2, 93, 40, 15, 37, 18, 12, 2, 2, 19, 8, 44, 120, 25, 120, 5, 0, 0, 0, 2, 48, 97, 102, 14, 3, 3, 11, 9, 34, 41, 0, 0, 4, 120, 56, 3, 4, 5, 6, 15, 37, 116, 28, 0, 0, 3, 120, 120, 24, 6, 2, 0, 1, 28, 53, 90, 51, 11, 11, 2, 12, 14, 8, 6, 4, 30, 9, 1, 4, 22, 25, 79, 120, 66, 5, 0, 0, 6, 42, 120, 91, 43, 15, 2, 4, 39, 12, 9, 9, 12, 15, 5, 24, 36]    4    [0, 0, 0]
-SET experimental_ivf_index = 0;
 drop database vecdb2;

test/distributed/cases/array/array_index_1.sql

@@ -1,5 +1,3 @@
-SET experimental_ivf_index = 1;
-
 -- pre
 drop database if exists vecdb2;
 create database vecdb2;
@@ -694,5 +692,4 @@ alter table vector_index_08 add column d vecf32(3) not null after c;
 select * from vector_index_08;
 
 -- post
-SET experimental_ivf_index = 0;
 drop database vecdb2;

test/distributed/cases/array/array_index_knn.result

@@ -1,4 +1,3 @@
-SET experimental_ivf_index = 1;
 SET probe_limit = 1;
 drop database if exists vecdb3;
 create database vecdb3;
@@ -11,11 +10,9 @@ insert into t6 values(3, "[3,0,0,0]", "3");
 insert into t6 values(4, "[11,11,0,0]", "4");
 insert into t6 values(5, "[12,12,0,0]", "5");
 insert into t6 values(6, "[13,13,0,0]", "6");
-SET experimental_ivf_index = 0;
 create index idx6 using ivfflat on t6(b) lists=2 op_type "vector_l2_ops";
-internal error: IVF index is not enabled
-SET experimental_ivf_index = 1;
 create index idx6 using ivfflat on t6(b) lists=2 op_type "vector_l2_ops";
+duplicate key name 'idx6'
 select a, b from t6 order by l2_distance(b, "[1,0,0,0]") limit 4;
 a    b
 1    [1, 0, 0, 0]
@@ -267,6 +264,5 @@ a    b
 7    [111, 111, 111, 0]
 8    [112, 112, 112, 0]
 11    [114, 114, 114, 0]
-SET experimental_ivf_index = 0;
 SET probe_limit = 5;
 drop database vecdb3;

test/distributed/cases/array/array_index_knn.sql

@@ -1,4 +1,3 @@
-SET experimental_ivf_index = 1;
 SET probe_limit = 1;
 
 -- pre
@@ -15,10 +14,8 @@ insert into t6 values(3, "[3,0,0,0]", "3");
 insert into t6 values(4, "[11,11,0,0]", "4");
 insert into t6 values(5, "[12,12,0,0]", "5");
 insert into t6 values(6, "[13,13,0,0]", "6");
-SET experimental_ivf_index = 0;
 
 create index idx6 using ivfflat on t6(b) lists=2 op_type "vector_l2_ops";
-SET experimental_ivf_index = 1;
 
 create index idx6 using ivfflat on t6(b) lists=2 op_type "vector_l2_ops";
 select a, b from t6 order by l2_distance(b, "[1,0,0,0]") limit 4;
@@ -184,6 +181,5 @@ insert into t5 values(11, "[114,114,114,0]", "11");
 select a, b from t5 order by l2_distance(b, "[111,111,111,0]") limit 7;
 
 -- post
-SET experimental_ivf_index = 0;
 SET probe_limit = 5;
 drop database vecdb3;