Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

/keys/signatures/upload is heavy and on the synapse master #6843

Open
ara4n opened this issue Feb 4, 2020 · 4 comments
Open

/keys/signatures/upload is heavy and on the synapse master #6843

ara4n opened this issue Feb 4, 2020 · 4 comments
Labels
A-Performance Performance, both client-facing and admin-facing A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-cross-signing (Deprecated Label) z-cross-signing-sprint (Deprecated Label)

Comments

@ara4n
Copy link
Member

ara4n commented Feb 4, 2020

It took ~30s to 'store secrets' on my account, and similarly on Amandine's.

2020-01-24 22:15:56,841 - synapse.access.http.8080 - 233 - INFO - POST-8145074 - 65.127.237.10 - 8080 - Received request: POST /_matrix/client/unstable/keys/signatures/upload
2020-01-24 22:16:22,132 - synapse.handlers.device - 429 - DEBUG - POST-8145074 - Notifying about update '@matthew:matrix.org'/'RQRQBRNDOP', ID: 20726543
2020-01-24 22:16:22,134 - synapse.handlers.device - 438 - INFO - POST-8145074 - Sending device list update notif for '@matthew:matrix.org' to: { <4510 homeservers> }
2020-01-24 22:16:22,600 - synapse.access.http.8080 - 302 - INFO - POST-8145074 - 65.127.237.10 - 8080 - {@matthew:matrix.org} Processed request: 25.756sec/0.003sec (1.734sec, 0.415sec) (3.563sec/11.775sec/2210) 16B 200 "POST /_matrix/client/unstable/keys/signatures/upload HTTP/1.1" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.117 Safari/537.36" [0 dbevts]

Surely this shouldn't be on the master. (And should perhaps be an async API if it's going to take so long). See element-hq/element-web#12223 for the Riot side of this.

@uhoreg
Copy link
Member

uhoreg commented Feb 4, 2020

IIRC, device updates use the same function for notifying, so they probably have the same issue

@jryans jryans added the phase:2 label Feb 10, 2020
@richvdh
Copy link
Member

richvdh commented Mar 19, 2020

@neilisfragile to try to understand what exactly the effect of this is

@neilisfragile
Copy link
Contributor

Not a release blocker, more a nice to have

@richvdh
Copy link
Member

richvdh commented Apr 30, 2020

we will revisit this once Operation Gemini has progressed somewhat.

@richvdh richvdh removed the phase:2 label Oct 1, 2020
@jryans jryans removed the z-story:1 label Mar 5, 2021
@MadLittleMods MadLittleMods added the z-cross-signing (Deprecated Label) label Jun 28, 2023
@MadLittleMods MadLittleMods changed the title /keys/signatures/upload is heavy and on the synapse master /keys/signatures/upload is heavy and on the synapse master Jun 28, 2023
@MadLittleMods MadLittleMods added A-Performance Performance, both client-facing and admin-facing A-Workers Problems related to running Synapse in Worker Mode (or replication) S-Minor Blocks non-critical functionality, workarounds exist. O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Performance Performance, both client-facing and admin-facing A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-cross-signing (Deprecated Label) z-cross-signing-sprint (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

6 participants