Skip to content

Commit a171d5f

Browse files
committed
Check for a state_key on the tombstone push rule
This is an oversight from the proposal.
1 parent 3087c76 commit a171d5f

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add a missing ``state_key`` check on ``.m.rule.tombstone``.

proposals/1930-tombstone-notifications.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ A new default override rule is to be added which is similar to `@room` notificat
1919
"kind": "event_match",
2020
"key": "type",
2121
"pattern": "m.room.tombstone"
22+
},
23+
{
24+
"kind": "event_match",
25+
"key": "state_key",
26+
"pattern": ""
2227
}
2328
],
2429
"actions": [

specification/modules/push.rst

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ Definition:
382382
383383
``.m.rule.tombstone``
384384
`````````````````````
385-
Matches any event whose type is ``m.room.tombstone``. This is intended
385+
Matches any state event whose type is ``m.room.tombstone``. This is intended
386386
to notify users of a room when it is upgraded, similar to what an
387387
``@room`` notification would accomplish.
388388

@@ -399,6 +399,11 @@ Definition:
399399
"kind": "event_match",
400400
"key": "type",
401401
"pattern": "m.room.tombstone"
402+
},
403+
{
404+
"kind": "event_match",
405+
"key": "state_key",
406+
"pattern": ""
402407
}
403408
],
404409
"actions": [

0 commit comments

Comments
 (0)