Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacements and redactions for pinned events aren't working in real-time #4643

Open
jmartinesp opened this issue Feb 7, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@jmartinesp
Copy link
Contributor

When we call PinnedEventsLoader::load_events, this will:

  • Fetch the pinned event ids for the room.
  • For each of those ids, load the associated event from the event cache if present, otherwise request it from the HS.
  • Then it'll check if there are already any events in the event cache that are either a replacement or a redaction of this pinned event, and return it too. This shouldn't be a problem for replacements, since they should be aggregated server-side inside the original event, and neither should it be for redactions, since the server should include the redaction info in the unsigned json contents.

This means for pinned events if we receive some of these related-to-pinned-events events in the sync, the current list of pinned events won't change until it's manually reloaded.

It would be nice to have some way to check whether a new event that's either a replacement or a redaction modifies a pinned event id in a room and broadcast that so we can reload the pinned event timeline as needed.

@jmartinesp jmartinesp added the enhancement New feature or request label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant