Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the reply fallback to the InReplyToDetails for use while loading. #4148

Open
pixlwave opened this issue Oct 17, 2024 · 1 comment
Open
Labels
A-Timeline enhancement New feature or request

Comments

@pixlwave
Copy link
Member

Today I encountered an issue where Element X showed a loading placeholder for a reply to a message that wasn't available to my client.

94CE87AE-E216-4DFD-818A-C4379A2D2DE5

Ignoring the fact that it didn't transition to some kind of failure UI, @BillCarsonFr pointed out that there's the fallback reply which is always available in an event:

Screenshot 2024-10-17 at 3 45 12 pm

Which leads me to realise that if we included the (properly extracted and formatted) fallback reply in the InReplyToDetails we could render this while loading the actual event (and if the load fails, there is still something to show).

@bnjbvr bnjbvr added enhancement New feature or request A-Timeline labels Oct 22, 2024
@zecakeh
Copy link
Collaborator

zecakeh commented Nov 13, 2024

Reply fallbacks will be gone in the next version of the spec (most likely), and removed in Ruma probably before that.

Context: MSC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants