Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single event doesn't appear on Dashboard #468

Open
nostromoo opened this issue Jan 11, 2024 · 4 comments · May be fixed by #470
Open

Single event doesn't appear on Dashboard #468

nostromoo opened this issue Jan 11, 2024 · 4 comments · May be fixed by #470

Comments

@nostromoo
Copy link

Hello,

We are using the android Matomo SDK version 4.1.4. We have notice that when we log one single event on a dispatchInterval period, it doesn't appear in the dashboard, but when there are several, it works fine.

After analysing the code of the Matomo sdk, I notice that to report a single event, the SDK is doing a http GET request and if there are more than one a http POST request (see send() method in DefaultPacketSender).

I tried to fork the Matomo SDK and modify the code to ensure that we use the POST call all the time, and it works fine.

Could you fix the issue please? Or tell us if there is a problem in our integration?

Thanks.
@hannesa2
Copy link
Collaborator

When you fixed it, it would be fine, when you make a pull request for it

@nostromoo
Copy link
Author

I have an error when I try to push my branch :

remote: Permission to matomo-org/matomo-sdk-android.git denied to nostromoo.
fatal: unable to access 'https://github.com/matomo-org/matomo-sdk-android.git/': The requested URL returned error: 403

I tried with username/password and accessToken login

@hannesa2
Copy link
Collaborator

You are not allowed to push to this repository, you need first an own fork.
image
Add this as a new remote to your repository and push it there.
With this you can make a pull request.

Here you have the long and complete story https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests

@nostromoo
Copy link
Author

Thank you for your reply, it's done :
#470

@hannesa2 hannesa2 linked a pull request Jan 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send packet only with POST method. nostromoo/matomo-sdk-android
2 participants
@hannesa2 @nostromoo