Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistiency of marking external links with an icon #4130

Open
zackkrida opened this issue Jan 14, 2025 · 1 comment
Open

Improve consistiency of marking external links with an icon #4130

zackkrida opened this issue Jan 14, 2025 · 1 comment
Labels
affects: ux Related to user experience work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@zackkrida
Copy link
Contributor

Problem

Identified by @seancolsen in #4126 (comment).

Mathesar includes a number of "external" links; for example, links out to the documentation site. Some of these use an icon to indicate that you will be leaving Mathesar. Others do not.

Proposed solution

Move the "external hyperlink" icon into the DocsLink component so that it appears everywhere. This would require visual inspection to make sure it looks correct in all the different usages of the DocsLink component.

Additional context

@zackkrida zackkrida added type: enhancement affects: ux Related to user experience work: frontend Related to frontend code in the mathesar_ui directory labels Jan 14, 2025
@kgodey kgodey added this to the Backlog milestone Jan 15, 2025
@kgodey
Copy link
Contributor

kgodey commented Jan 15, 2025

@zackkrida Can you mark this with either a ready or some sort of needs: label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: ux Related to user experience work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
Development

No branches or pull requests

2 participants