Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_stokes example uses undefined attribute history #71

Closed
Pratere opened this issue Mar 3, 2023 · 1 comment
Closed

run_stokes example uses undefined attribute history #71

Pratere opened this issue Mar 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Pratere
Copy link
Contributor

Pratere commented Mar 3, 2023

Describe the bug
The example run_stokes.py attempts to save out history on ln 43:

for i, losses in enumerate(pinn.history):

The PINN class has no attribute history, this line results in an AttributeError.

To Reproduce
python examples/run_stokes.py -s 1

Expected behavior
A file to be saved with loss history for run.

Output

Traceback (most recent call last):
  File "/Users/eliprater/Documents/Projects/PINA/examples/run_stokes.py", line 43, in <module>
    for i, losses in enumerate(pinn.history):
AttributeError: 'PINN' object has no attribute 'history'

Additional context
Was it was meant for this line to reference the PINN attribute history_loss?

In that case the line could be changed to:

for i, losses in pinn.history_loss.items():

@Pratere Pratere added the bug Something isn't working label Mar 3, 2023
@Pratere
Copy link
Contributor Author

Pratere commented Mar 3, 2023

Commit 936f5e1 changed the attribute history, which was a list, to history_loss, which is a dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant