-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Comments to the Examples #103
Comments
In fact, I think it would be superb to convert some of the examples into notebooks. Some of these examples seem small, even possibly trainable on CPUs. It would be good to have notebooks that clearly show the logging during the progress, the kind of outputs it generates, and how to do inferencing and make plots. |
👋🏻 @yorkiva Thanks for the feedback! Indeed you are right, we will add comments to the examples. Some of the interesting problems (e.g Stokes) are a bit too long to train on a notebook, but we have a list of possible tutorials here in |
👋🏻 @yorkiva . I updated the example folder (see #105), so now every problem in We will soon release a beta version of PINA where some high level features will change (rename some classes, and add more flexibility for the user by enabling pytorch lightining). Since updating the tutorial requires a big effort (for documentation compatibility, etc.), and due to the soon release of the beta verison, we will not make a tutorial on Stokes (but you can see the working example in Anyway, thank you for the feedback, we will also take into account when working on the beta version #85 . |
@yorkiva - is this ok to close now? |
Thanks for the response. This can be closed now. |
Is your feature request related to a problem? Please describe.
The package contains a good set of examples. But their comprehensibility is not up to the mark, especially for someone who is just starting with the package and not yet familiar with the different modules and their utilities.
Describe the solution you'd like
In the examples, comments should be added to make it clear what problem is being solved, what are the domains, constraints etc. Additional comments should be added to clearly illustrate what different parts of the code are accomplishing.
Describe alternatives you've considered
Additional context
openjournals/joss-reviews#5352
The text was updated successfully, but these errors were encountered: