-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantics #3
Comments
Thanks @samwaseda! I had a quick look, and expanded a bit on the text in #4.
I'm not sure what you mean here? I was actually wondering about the functions of an input parser. In the context of e.g. VASP, should it both be able to:
The answer to (1) seems like an obvious yes, but (2) I would not call "parsing". More like "input file generation". ^^ One distinction between input/output parsers is that you typically don't need an output parser to be able to generate the contents of e.g. a VASP
It's an interesting point, and I hadn't considered this in the context of parsing. Is taking the output of a Python function (e.g. a Let's say we would write an output parser for the VASP Footnotes
|
ah, an interesting point. I was blindly thinking about 2., but it's true that if we stick to the term "parser", it makes more sense to talk about 1., although in the concept of a workflow, it's more about 2. So my suggestion was related to 2., and it would more specifically look like this: def write_incar(incar_dict, cwd):
with open(cwd + "/INCAR", "w") as f:
for k, v in incar_dict.items():
f.write(k + " " + str(v) + "\n")
return None |
@mbercx @jan-janssen @JaGeo @schaarj
I started creating semantics.md. The definition of
parser
is more or less what @mbercx and I agreed on, but there are the following points I was not so sure about:And on top of this, we might have to make a distinction between requirements and recommendations.
By the way, obviously you are also very welcome to make changes there.
The text was updated successfully, but these errors were encountered: