Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace state$ with atRest$ #235

Open
appsforartists opened this issue Oct 22, 2017 · 0 comments
Open

Replace state$ with atRest$ #235

appsforartists opened this issue Oct 22, 2017 · 0 comments

Comments

@appsforartists
Copy link
Member

We changed from atRest$ to state$ because some members of the core team had strong feelings about it being enumerated (I think they found atRest:true to be strange to reason about). We should revisit this decision:

  • We have aggregators now that work on true/false. If state$ is emitting enums, we have to manually map state$ to true/false or can't use the aggregators. For instance, see the complexity in aggregating tossable.state$
  • Interactions often interact with state machines: for instance, whether a bottom sheet is open or closed. state$ makes more sense as a name for interaction-specific state than for activity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant