style(tab): Clean up z-indices to allow non-transparent backgrounds on tabs without breaking tab switch animations.

sn-kaier · copybara-github · commit a206df31fff4 · 2022-12-02T03:34:25.000-08:00
PiperOrigin-RevId: 492205902
diff --git a/packages/mdc-tab/_mixins.scss b/packages/mdc-tab/_mixins.scss
@@ -63,7 +63,6 @@
       white-space: nowrap;
       cursor: pointer;
       -webkit-appearance: none;
-      z-index: 1;
 
       // Firefox still draws a dotted border around focused buttons unless specifically overridden.
       &::-moz-focus-inner {
@@ -326,8 +325,6 @@
 
       @include feature-targeting.targets($feat-structure) {
         margin-top: -2px;
-        // Set z-index to +1 above the .mdc-tab
-        z-index: 2;
       }
     }
 
@@ -338,11 +335,6 @@
         $container-outer-padding-vertical: -4px,
         $container-outer-padding-horizontal: -4px
       );
-
-      @include feature-targeting.targets($feat-structure) {
-        // Set z-index to +1 above the .mdc-tab
-        z-index: 2;
-      }
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,6 @@`
`63`	`63`	`white-space: nowrap;`
`64`	`64`	`cursor: pointer;`
`65`	`65`	`-webkit-appearance: none;`
`66`		`- z-index: 1;`
`67`	`66`
`68`	`67`	`// Firefox still draws a dotted border around focused buttons unless specifically overridden.`
`69`	`68`	`&::-moz-focus-inner {`
`@@ -326,8 +325,6 @@`
`326`	`325`
`327`	`326`	`@include feature-targeting.targets($feat-structure) {`
`328`	`327`	`margin-top: -2px;`
`329`		`- // Set z-index to +1 above the .mdc-tab`
`330`		`- z-index: 2;`
`331`	`328`	`}`
`332`	`329`	`}`
`333`	`330`
`@@ -338,11 +335,6 @@`
`338`	`335`	`$container-outer-padding-vertical: -4px,`
`339`	`336`	`$container-outer-padding-horizontal: -4px`
`340`	`337`	`);`
`341`		`-`
`342`		`- @include feature-targeting.targets($feat-structure) {`
`343`		`- // Set z-index to +1 above the .mdc-tab`
`344`		`- z-index: 2;`
`345`		`- }`
`346`	`338`	`}`
`347`	`339`	`}`
`348`	`340`	`}`