Build issue with a lot of languages

[raveit65]

Expected behaviour

Builds fine after latest pull from transifex.

Actual behaviour

Build failed after latest pull from transifex.

Steps to reproduce the behaviour

At master:
git revert 9bf5095
./autogen.sh && make
Building failed with

be.po:888: 'msgstr' is not a valid C format string, unlike 'msgid'. Reason: The character that terminates the directive number 1 is not a valid conversion specifier.
be.po:893: 'msgstr' is not a valid C format string, unlike 'msgid'. Reason: The character that terminates the directive number 1 is not a valid conversion specifier.
/usr/bin/msgfmt: found 2 fatal errors
be.po: 298 translated messages, 31 untranslated messages.
make[3]: *** [Makefile:203: be.gmo] Error 1

This happens with 29 languages at the place!

MATE general version

1.23

Package version

1.23.0

Linux Distribution

All

Link to downstream report of your Distribution

1.23.1 isn't build in any distro, so there aren't downstream reports.

I fixed building with 9bf5095 for generating 1.23.1 release.
But this will be override by next pull from transifex. So we need a real fix for it.
I assume it is a problem in our code because it affect a lot of languages.

[raveit65]

@mate-desktop/core-team
Huston we have a problem......

[cwendling]

Looks to me like the problem is that the Width of process '% CPU' column string is marked c-format, which it doesn't look like to be.

[cwendling]

Not sure how it works with gschemas and the current setup, but

mate-system-monitor/src/org.mate.system-monitor.gschema.xml.in

Line 288 in fc1f63b

<summary>Width of process '% CPU' column</summary>

should be marked as not being a C-formatted string. Well, all of this file should, I guess.

[lukefromdc]

I can confirm the temporary fix permits builds of 1.23.1 to complete on my system

[rbuj]

I've tried a number of things, adding the comment <!-- xgettext:no-c-format --> in gschema.xml file, replacing % with % also in gschema.xml file... but gettext failed to extract the messages to pot file. At the moment, manually removing the comment c-format from pot and all po files works, but we should disable their automatic update. (PR #187)

[monsta]

Hmm... in 1.22 branch these strings are marked as no-c-format in the potfile, though there are no related comments in the schema file. Was intltool so clever to auto-mark them?

#: ../src/org.mate.system-monitor.gschema.xml.in.h:43
#, no-c-format
msgid "Width of process '% CPU' column"
msgstr ""

#: ../src/org.mate.system-monitor.gschema.xml.in.h:45
#, no-c-format
msgid "Show process '% CPU' column on startup"
msgstr ""

[monsta]

@yetist: maybe you know how to make gettext to not use c-format with schemas...?

[raveit65]

Reopened, because the merged fix is more a band aid / work around.

[yetist]

Maybe we can refer to gnome-system-monitor?

org.gnome.gnome-system-monitor.gschema.xml:      <summary>Width of process “CPU %” column
org.gnome.gnome-system-monitor.gschema.xml:      <summary>Show process “CPU %” column on startup
org.mate.system-monitor.gschema.xml:      <summary>Width of process '% CPU' column</summary>
org.mate.system-monitor.gschema.xml:      <summary>Show process '% CPU' column on startup</summary>