add task solution #1527
Open
add task solution #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Nov 30, 2024
src/App.tsx
Outdated
|
|
||
| export const App: React.FC = () => { | ||
| // #region variables | ||
|
|
||
| const [value, setValue] = useState<string>(''); |
There was a problem hiding this comment.
it's redundant to specify types for primitives
Suggested change
| const [value, setValue] = useState<string>(''); | |
| const [value, setValue] = useState(''); |
src/App.tsx
Outdated
Comment on lines
80
to
86
| useEffect(() => { | ||
| if (completedTodos.length > 0 && completedTodos.length === todos.length) { | ||
| setAllCompleted(true); | ||
| } else if (allCompleted) { | ||
| setAllCompleted(false); | ||
| } | ||
| }, [allCompleted, completedTodos, todos.length]); |
There was a problem hiding this comment.
it's can just be the variable
const isAllCompleted = completedTodos.length > 0 && completedTodos.length === todos.length
src/App.tsx
Outdated
| const [error, setError] = useState<string>(''); | ||
| const [allCompleted, setAllCompleted] = useState<boolean>(false); | ||
| const [editedInputById, setEditedInputById] = useState<number>(-1); | ||
| const [key, setKey] = useState<string>(''); |
There was a problem hiding this comment.
we don't need a separate state for the key, feel free to ask for some help in the chat
src/App.tsx
Outdated
Comment on lines
58
to
60
| const [idsOfRecedingTodos, setIdsOfRecedingTodos] = useState<number[]>([]); | ||
| const [tempTodo, setTempTodo] = useState<Todo | null>(null); | ||
| const [idsOfTodosOnSelect, setIdsOfTodosOnSelect] = useState<number[]>([]); |
There was a problem hiding this comment.
I think idsOfRecedingTodos and idsOfTodosOnSelect can be united in one state
src/App.tsx
Outdated
Comment on lines
248
to
258
| function allSelected() { | ||
| setFilter(Filter.all); | ||
| } | ||
|
|
||
| function activeSelected() { | ||
| setFilter(Filter.active); | ||
| } | ||
|
|
||
| function completedSelected() { | ||
| setFilter(Filter.completed); | ||
| } |
There was a problem hiding this comment.
it's redundant to create three functions and pass them into Footer, just pass the setFilter function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK