Develop #2664
Develop #2664
Conversation
…ml, made working menu-burger with phone label
There was a problem hiding this comment.
Hey. Go through checklist one more time there are some things that aren't added.
Import logo image as SVG. Its in bad quality when oversized.
h1 Title is different than on Figma it also has underline. The bike image in the header is in bad position on tablets width.
There is title in the footer that is not in figma. Also image in footer is blurred on mobile.
…ground position for tablets width, fixed footer
There was a problem hiding this comment.
- When you click on phone icon or phone number in contacts section, make sure that there is no 404 error, make it a real link to start a call on device
- Location-related addresses / links should open google maps in a new tab target="_blank"
- Form shouldn't be submitted if some of the fields are not filled
- Page shouldn't be reloaded on form submit (https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault)
- disable page scrolling under the menu
…elated addresses, repaired problem with form, page scrolling in the menu is disabled
Hello, Can you expllain to me what should I fix in menu for small screens? |
There was a problem hiding this comment.
Almost done!
- On hover, the bigger image goes behind the smaller one! image
- Fix menu for small screens (if there is not enough space for all the menu items)
Hello, Can you expllain to me what should I fix in menu for small screens?
scroll is disabled so when the navigation list doesn't fit on small screens users can't scroll down to see all the options
You should be able to scroll inside menu but not whole page under it :)
checklist - here you have some tips how to do it
[DEMO LINK] (https://MateuszCieplak.github.io/layout_miami/)