Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding header and footer #2656

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

Karanelus
Copy link

@Karanelus Karanelus commented Jun 4, 2024

For this moment header is almost ready (without menu, opened after clicking a menu button) with ready footer.

https://karanelus.github.io/layout_miami/

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, to check your work by parts(I think only header ready) I need to see it, so add demo link to your PR

@Karanelus
Copy link
Author

Hello, to check your work by parts(I think only header ready) I need to see it, so add demo link to your PR

My bad, added link in start comment

@Karanelus Karanelus requested a review from BogdanMaliuta June 5, 2024 19:12
Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, in your header I can`t see menu button, because of image
image,
Also on smaller devices its not ready
image
And burger menu icon must be black
image

@Karanelus Karanelus requested a review from BogdanMaliuta June 9, 2024 17:24
@Karanelus
Copy link
Author

https://karanelus.github.io/layout_miami/

Added recommended section and burgerMenu, fixed some problems from last PR

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with header!

@Karanelus Karanelus requested a review from BogdanMaliuta June 14, 2024 17:12
@Karanelus
Copy link
Author

Added categories section and little edit of burger menu

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but on 570px breakpoint got smth like that:
image

@Karanelus Karanelus requested a review from BogdanMaliuta June 19, 2024 14:36
@Karanelus
Copy link
Author

The issue you’re describing occurs only when you shrink it to unrealistic sizes (for example, down to 50px) and then expand it again. Unfortunately, I don’t know how to fix it.

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but on 570px breakpoint got smth like that: image

to fix it try to remove min-width: 100dvh; style from body

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix resolution 744 and 743
image

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • on resolution < 742 your header stays in one place
  • disable scrolling while in burger menu

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigation stays in same place in resolution < 743
image
image

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this element should be in different size on mobile
image

image

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix all problems in my recent comments :)

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tablet have wrong size for logo and phone icon
image
and height of background image (it's too short)
image

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, fix that things:
Incorrect position of title
image
image
images
image
fix this also
image
Also check your adaptive

@Karanelus
Copy link
Author

Hello, fix that things: Incorrect position of title image image images image fix this also image Also check your adaptive

image
image

Don't know why but github pages ignore [class^="content"] condition, and that impacting all the page. Normally it's look like that on my computer:

FireShot Webpage Capture 074 - 'BOSE' - localhost

@Karanelus Karanelus requested a review from BogdanMaliuta July 1, 2024 16:19
Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it so that it looks good in every resolution:
image

@Karanelus
Copy link
Author

fix it so that it looks good in every resolution: image

Looks like on Chromium' browsers layout looks different
Try my best to fix that

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀 just need some final improvements ;)
Checklist:

  • All Logos on the page should be links to home page
  • Change text color on hover for phone, email and address
  • When you click on phone icon or phone number in contacts section, make sure that there is no 404 error, make it a real link to start a call on device
  • When clicking on any location / address - prevent errors and make it to open location in Google Maps
  • Pictures in Gallery should increase on hover
  • Page shouldn't be reloaded on form submit (https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault)

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants