Develop #2653
Open
Develop #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgGugala
commented
Apr 15, 2024
•
kgGugala
commented
- MYBIKE landing
- DEMO https://kgGugala.github.io/layout_miami/
yevhenii-pyl
suggested changes
Apr 16, 2024
yevhenii-pyl
suggested changes
May 20, 2024
| .navigation { | ||
| display: flex; | ||
| align-items: center; | ||
| padding: 24px 0 0; |
There was a problem hiding this comment.
I'd probably set this property as padding-top for the header.
As a general rule, the parent container should be responsible for positioning it's children. Not a mistake here, but a possibility for cleaner approach.
|
|
||
| @include for-tablet { | ||
| grid-column: 1 / 7; | ||
| padding-bottom: 40px; |
There was a problem hiding this comment.
Maybe, it would make sense to position nav and title using grid-row property, but also not a mistake here, just a possible second approach.
|
|
||
| @include for-desktop { | ||
| grid-column: 1 / 5 ; | ||
| margin-top: 120px; |
There was a problem hiding this comment.
I'd create a separate container for this title && paragraph block to ease the positioning.
yevhenii-pyl
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.