Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade: HSL interpolation #426

Open
SimplyMerlin opened this issue Feb 22, 2021 · 8 comments
Open

Fade: HSL interpolation #426

SimplyMerlin opened this issue Feb 22, 2021 · 8 comments
Assignees
Labels
device Issue in Device enhancement New feature or request
Milestone

Comments

@SimplyMerlin
Copy link

SimplyMerlin commented Feb 22, 2021

Is your feature request related to a problem? Please describe.

no

Describe the solution you'd like

Change the way of interpolating colors in the fade device from RGB to HSL for cleaner fades

Describe alternatives you've considered

Add a checkbox to turn on HSL interpolation instead of completely replacing it

Your setup

Windows, latest lol

Additional context

uh oh stinky uh oh stinky

@SimplyMerlin SimplyMerlin added the enhancement New feature or request label Feb 22, 2021
@mat1jaczyyy
Copy link
Owner

will have to be optional due to this fun little thing called backwards compatibility

@mat1jaczyyy mat1jaczyyy added the device Issue in Device label Feb 23, 2021
@mat1jaczyyy mat1jaczyyy added this to the 1.9.0 milestone Feb 23, 2021
@mat1jaczyyy mat1jaczyyy changed the title HSL interpolation for fade device Fade: HSL interpolation Feb 23, 2021
@Brendonovich
Copy link
Collaborator

ye for sure

@SimplyMerlin
Copy link
Author

will have to be optional due to this fun little thing called backwards compatibility

i mean or you can just pull a Mathematica

@mat1jaczyyy
Copy link
Owner

@Brendonovich were you working on this at any point, i vaguely remember you had a WIP perhaps?

@Brendonovich
Copy link
Collaborator

woah this project is alive again?
idk where the branch is haha, it's probs somewhere but I'd have to go looking

@mat1jaczyyy
Copy link
Owner

#442 (comment)
only because this comment had further ramifications

@Brendonovich
Copy link
Collaborator

oh shit fairo

@mat1jaczyyy
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device Issue in Device enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants