Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP integration #25

Open
filmil opened this issue Nov 15, 2023 · 1 comment
Open

LSP integration #25

filmil opened this issue Nov 15, 2023 · 1 comment

Comments

@filmil
Copy link
Contributor

filmil commented Nov 15, 2023

It might be interesting to turn private_comments into a LSP server. This would give you a worked-out UI and a ready-made integration for most modern editors. I couldn't figure out if the "write" sub-API would be supported by LSP, which leaves something to be desired, but I'm not giving up this avenue of thought just yet.

Granted, the LSP API is different from what private_comments uses today, but that seems fixable.

@filmil
Copy link
Contributor Author

filmil commented Feb 11, 2024

FWIW, I took a shot at https://github.com/filmil/private-code-comments.
This is a LSP server, and I wrote a rudimentary, and still rather buggy integration with Neovim.
It should be possible to integrate it with any LSP client.
The project shares no code base with private_comments, but is obviously inspired by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant