Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soulname V2 Scoping #361

Open
6 tasks
teslashibe opened this issue Jan 24, 2024 · 3 comments
Open
6 tasks

Soulname V2 Scoping #361

teslashibe opened this issue Jan 24, 2024 · 3 comments
Assignees

Comments

@teslashibe
Copy link
Contributor

teslashibe commented Jan 24, 2024

@miquelcabot @H34D we can we remove non-native paymetns from the scope of the Soulname v2 contract - we have only $400 in USDC payments through the soulstore - we should kill multi-currency support in v2 to simplify code. This is thinking generally about this no matter what network it is on its an unused feature and we can make things simpler by killing the feature.

Subnet context

There is no payment provider on the network (because its completely blank) which means we can not use the Payment gateway we have to do payments for soul names and SBT mints like we do on the other networks. Even when there is a swap provider we would need to decide how we handle liquidity and trading pairs there. Because its most likely that the liquidity is close to zero on a tool chain.

Research scoping

This scope needs to be formalized before we ship this to testnet and production.

  • Remove multi-currency support
  • Remove dependency on middleware
  • Review and update emitted events to consolidate and make simpler for indexing
  • Review OpenSea specifications for expired soulnames
  • Think about migrating to ENS stack to be compatible with the entire ETH ecosystem

Current V2 Status

@miquelcabot to add the current status of V2 in bullet points

  • Renewal with payments

https://www.notion.so/masafinance/Soulname-renewal-Soulstore-v2-contract-3c28979be6cd4ef69e6f7871f511dfc0?pvs=4

@H34D
Copy link
Contributor

H34D commented Jan 25, 2024

  • Remove multi-currency support

Right now we support two types of payment methods: native asset and ERC20 tokens. Based on the discussion we had on slack this means to remove the swap functionality which would remove the functionality to oracelise the price of a given stablecoin like USDC. That means that all prices have to be defined in their given asset. This would make a SoulName cost 0.0002 ETH instead of 100$ equivalent in ETH.

@H34D
Copy link
Contributor

H34D commented Jan 25, 2024

  • Remove dependency on middleware

Right now we do all the computation in the middleware when it comes to validity and char set checks. Also the length is determined by the middleware. The middleware generates and stores all the assets (metadata + image) in arweave. I would not know how to remove the middleware here. Or does this means something else?

@H34D
Copy link
Contributor

H34D commented Jan 25, 2024

[ ] Review OpenSea specifications for expired soulnames

from my research yesterday, opensea does not "support" that. What we can do is to store the expiration date as trait in the metadata file. But since we decided to have immutable metdata and store them in arweave we can not change the metadata. ENS stores metadata on their premises and is able to change all the values at any time. We could replicate the same behaviour and store the metdata in a database and stream it via the middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants