Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin installation fails if default path is inaccessible #108

Open
PixelHir opened this issue Aug 13, 2024 · 6 comments
Open

Plugin installation fails if default path is inaccessible #108

PixelHir opened this issue Aug 13, 2024 · 6 comments

Comments

@PixelHir
Copy link

image

Not sure if I have some unusual home directory permissions but IINACT was unable to create an IINACT folder in my documents folder.
I created it manually and it worked however it feels a bit unusual for plugin to instantly fail like that - especially if a user could wish to instantly change their IINACT directory on start. Maybe it would be better if user could be still able to install plugin even if IINACT can't access the folder - and inform them appropriately to grant permission or change destination folder?

@marzent
Copy link
Owner

marzent commented Aug 19, 2024

This is unfortunately not really feasible, since the FFXIV_ACT_Plugin needs to be initialized together with IINACT and at the point in time it is not possible to show a popup or folder selection dialog (at least not without rewriting basically the entire plugin startup sequence)...
But I am wondering, are you running some kind of AV that blocks certain actions in the Documents folder? If so an exclusion for Dalamud and all its plugins would probably also work here.

@PixelHir
Copy link
Author

I only have the installed by default windows defender - I have completely no idea why the access was denied as I remember it used to work, maybe that’s some new 24H2 quirk…

@PixelHir
Copy link
Author

Oh never mind, it’s not about the permission, I copied plugin configs from my old windows install and the user folder has changed - so that one doesn’t exist. My bad, needed to take a look at the log one more time. Although I have created the new folder in new user folder and it worked after that so I’m not sure if some fallback triggered or something…

@Koenari
Copy link

Koenari commented Dec 22, 2024

Happened to me just now. Underlying problem seems to be that DefaultLogFIlePath is written to the config file.
This field is missing a [JsonIgnore] and therefore it is possibly defaulting to the wrong user folder.

public string DefaultLogFilePath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments), "IINACT");

@marzent
Copy link
Owner

marzent commented Dec 31, 2024

Indeed you are right, thanks for the catch @Koenari

@marzent
Copy link
Owner

marzent commented Dec 31, 2024

Part of this issue is fixed in 2.7.3.5 now, I'll still leave this one open though as that scenario could still be handled a bit more gracefully...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants