Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy dependencies from the config class #134

Open
seblemaguer opened this issue Sep 8, 2020 · 3 comments
Open

Groovy dependencies from the config class #134

seblemaguer opened this issue Sep 8, 2020 · 3 comments
Assignees

Comments

@seblemaguer
Copy link
Member

There is a groovy dependency leaking after building the voices.

@psibre I don't use groovy so that is your business now :D

@psibre
Copy link
Member

psibre commented Sep 10, 2020

Hummm. IIRC the idea was to not leak the Groovy dependency into the runtime classpath. If there is any requirement for Groovy at runtime, the voice should declare its own dependency.

@psibre
Copy link
Member

psibre commented Sep 10, 2020

@seblemaguer Is this a problem with all voices, or just specific ones? Can you point me to an example?

@psibre
Copy link
Member

psibre commented Sep 10, 2020

The component plugin does generate Groovy code for the Config class, which is of course compiled by Groovy at build time, but that should not require Groovy at runtime. (Unlike, say, marytts-lang-lb...)

@seblemaguer seblemaguer assigned seblemaguer and unassigned psibre Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants