Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some durations == -1 #133

Open
seblemaguer opened this issue Sep 8, 2020 · 2 comments
Open

some durations == -1 #133

seblemaguer opened this issue Sep 8, 2020 · 2 comments

Comments

@seblemaguer
Copy link
Member

In the task f0ContourFeatureFileMaker, at this line:

long tsSylEnd = units.getUnit(syl.getLastUnitIndex()).startTime + units.getUnit(syl.getLastUnitIndex()).duration;

the duration of the unit == -1 which leads to fails the following assert

@seblemaguer
Copy link
Member Author

@psibre is there a reason for this:

out.writeLong(utteranceEndSample + unitStartSample)
out.writeInt(-1)
numUnits++

????

@psibre
Copy link
Member

psibre commented Sep 10, 2020

This is taken from

https://github.com/marytts/marytts/blob/c0df394604169fe520efd1d95d9b627309d9032f/marytts-builder/src/main/java/marytts/tools/voiceimport/PhoneUnitfileWriter.java#L150-L153

The Timeline format marks the boundary units as having duration -1; IIRC there are even some parts in the code where this antipattern is used to check if a unit is a boundary. =(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants