Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Switch from RUST_LOG to JJ_LOG #4219

Open
theduke opened this issue Aug 5, 2024 · 2 comments · May be fixed by #4350
Open

FR: Switch from RUST_LOG to JJ_LOG #4219

theduke opened this issue Aug 5, 2024 · 2 comments · May be fixed by #4350
Labels
enhancement New feature or request

Comments

@theduke
Copy link

theduke commented Aug 5, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

I work on a lot of Rust projects, and I often set the RUST_LOG env var, either manually or automatically with direnv.

This means that I end up seeing jj logs , even if I absolutely don't care about them.

Rust itself switched from RUST_LOG over to RUSTC_LOG quite a while ago, with a similar motivation.

Describe the solution you'd like

Since jj will be used in (Rust) development environments, it makes sense to :

  • Stop respecting the RUST_LOG env var
  • use JJ_LOG for logging configuration instead

Happy to open a PR for this if agreed upon.
@PhilipMetzger PhilipMetzger added the enhancement New feature or request label Aug 5, 2024
@arxanas
Copy link
Collaborator

arxanas commented Aug 6, 2024

I'm in favor. We already have JJ_TRACE as well.

@ilyagr
Copy link
Collaborator

ilyagr commented Aug 6, 2024

As a slight aside, it would be nice to document the relationship between the --debug option, JJ_TRACE, and the new JJ_LOG.

@theduke theduke linked a pull request Aug 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use JJ_LOG instead of RUST_LOG for tracing configuration theduke/jj
4 participants
@theduke @arxanas @ilyagr @PhilipMetzger