Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span_FEATURE_MAKE_SPAN #33

Closed
7 tasks done
martinmoene opened this issue Jan 16, 2019 · 1 comment
Closed
7 tasks done

Add span_FEATURE_MAKE_SPAN #33

martinmoene opened this issue Jan 16, 2019 · 1 comment

Comments

@martinmoene
Copy link
Owner

martinmoene commented Jan 16, 2019

Add configuration flag span_FEATURE_MAKE_SPAN to unconditionally control presence of make_span()

Plan:

  • Add span_FEATURE_MAKE_SPAN with priority above span_FEATURE_MAKE_SPAN_TO_STD
  • Add span_FEATURE_MAKE_SPAN to test/span-main.t.cpp
  • Document span_FEATURE_MAKE_SPAN, mentioning it precedes over span_FEATURE_MAKE_SPAN_TO_STD
  • In documentation of span_FEATURE_MAKE_SPAN_TO_STD, mention span_FEATURE_MAKE_SPAN takes precedence
  • Mention macro in table
  • Mention span_FEATURE_MAKE_SPAN in test/CMakeLists.txt
  • Mention span_FEATURE_MAKE_SPAN in test/t.bat, tg.bat, tc.bat

Originates from issue #32 .

Envisioned implementation:

#ifndef  span_FEATURE_MAKE_SPAN
#ifdef   span_FEATURE_MAKE_SPAN_TO_STD
# define span_FEATURE_MAKE_SPAN  span_IN_STD( span_FEATURE_MAKE_SPAN_TO_STD )
#else
# define span_FEATURE_MAKE_SPAN  0
#endif
#endif
@Flamefire
Copy link

Please do the same for all other *_TO_STD macros. Especially as e.g. the subspan function rely on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants