Skip to content

Commit 26a9e8b

Browse files
committed
fix: relax nullable rule checks
as the result of disscussion at: https://github.com/xeptore/commitiquette/pull/1#pullrequestreview-626057744, we decided to revert back to '== null' checks.
1 parent 72797a8 commit 26a9e8b

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/filters.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import wordWrap from 'word-wrap';
44
import { wordCase } from './utils';
55

66
export function leadingBlankFilter(value: string, rule: RuleConfigTuple<undefined> | undefined): string {
7-
if (rule === undefined) {
7+
if (rule == null) {
88
return value;
99
}
1010

@@ -26,7 +26,7 @@ export function leadingBlankFilter(value: string, rule: RuleConfigTuple<undefine
2626
}
2727

2828
export function fullStopFilter(value: string, rule: QualifiedRules['subject-full-stop'] | undefined): string {
29-
if (rule === undefined) {
29+
if (rule == null) {
3030
return value;
3131
}
3232

src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export function wordCase(value: string, rule: TargetCaseType): string {
4545
}
4646

4747
export function valueFromRule<T>(rule: RuleConfigTuple<T> | undefined): undefined | T {
48-
if (rule === undefined) {
48+
if (rule == null) {
4949
return undefined;
5050
}
5151

src/validators.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export function validate(
1717
): string | true {
1818
const errorMessages: string[] = validators
1919
.map(v => {
20-
if (v.rule === undefined) {
20+
if (v.rule == null) {
2121
return true;
2222
}
2323

src/when.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import type { RuleConfigTuple } from '@commitlint/types';
22
import { RuleConfigSeverity } from '@commitlint/types';
33

44
export function enumWhen(rule: RuleConfigTuple<string[]> | undefined): boolean {
5-
if (rule === undefined) {
5+
if (rule == null) {
66
return true;
77
}
88

@@ -22,7 +22,7 @@ export function enumWhen(rule: RuleConfigTuple<string[]> | undefined): boolean {
2222
}
2323

2424
export function emptyWhen(rule: RuleConfigTuple<undefined> | undefined): boolean {
25-
if (rule === undefined) {
25+
if (rule == null) {
2626
return true;
2727
}
2828

0 commit comments

Comments
 (0)